Bug [2653477] ArrayIndexOutOfBoundsException in Embellishment.getLocalized
and I think it also resolves
Bug [2432256] ArrayIndexOutOfBoundsException in Embellishment
When an Embelishment is very first created, it has zero levels defined, but the Activate command is still active. If the developer forgets to actually define any levels for the Layer, and a player activates a counter with no levels, one of the two errors above can occur.
The solution was simple - If a counter has zero levels, disable the Activate command. This also gives a clear feedback to the developer/players that something is wrong with the counter.
At some point we’ll want to release 3.1.1 from the 3.1 branch, maybe in
a few weeks once we’ve collected and solved most of the bug reports
we’ll see from 3.1.0.
Bug [2665747] NPE in MovementReporter reporting Drag & Drop move
This was caused by a Map auto-after-move key causing a piece to replace itself
with another piece while being stacked into an empty deck.
Movement reporting was happening after the auto-after-move key instead of before. By the time the movement reporter ran, the piece no longer existed.
I have moved the reporting of the movement from after the auti-after-move key to before so that it reports on the actual pieces moved before any are replaced.
This has been showing up regularly in the D&D Miniatures Skirmish module.
I wouldn’t wait too long. I was thinking every 2 weeks or so for the first few. This last bug I fixed shows up regularly in the D&D Skirmish module which is one of the most popular modules. There is probably enough there to warrant a release real soon now.
I just uploaded a 3.1.1 svn build in the usual place. 3.1.1 for the end of
next week sounds fine to me, or we could do it even sooner (we could do it
today, even).
Bug [2630529] NPE in ModuleManager displaying newly added module info
The NPE will no longer occur because I am now (correctly) checking that the metadata generated for a module is valid before trying to add the module to the Module Manager.
The question now is why is the metadata failing to be generated for a module that has just been successfully opened? It is a pretty uncommon error and the only side effect is that the module does not get automatically added to the Module Manager on this invocation. I am not going to actively persue this bug now, but have left the sourceforge entry open until someone can reproduce it at will.
With that fix, it’s unlikely that we’ll have any more reports of this bug,
since without the NPE there won’t be a Bug Dialog shown when it happens.
I’m not saying that the fix is bad, just that I’m not sure how we’ll find
the other bug now.
It looks like the metadata can fail to be valid either by being null or
by not being module metadata. The bug report says “Openning a .log for Drive
on paris”. Suppose we take that literally. Is it possible that the user
triggered this by trying to load a log file as a module?
I’ll try and have another look at this today. I did follow up on the loading ‘.log’ as module, but didn’t find anything. Need to check how it handles launching a saved file when the module has not been seen before.
Can you make a 3.1.1 build after merging this one in? I need to send it to a user to assist with debugging thia problem. The bug is nasty, but only affects a few people. I have one user now who get’s this every time they try and run the tour mod. The mod is actually a useful logging enhancement that will stay in after we fix the bug.
You’ve been on a tear fixing bugs the last few days. I’m almost to the
point where I can’t do further work on the new site until I get database
dumps from Rodney (nudge! nudge!), so I’ll soon switch to getting the
trunk working again if none of the data for the new site materialize.
The Turn Counter bugs have been there always. A few of the others have been introduced by 3.1 MM changes. Some have been the result of flow-on from other bug fixes. A mixture basically.