3.2 builds

And brent-3.2@7825 adds a missing Help button to the Mass Piece Loader (No help page written yet).

Thus spake pgeerkens:

My problem is something different: I am developing a game, and when I am
in the editor the board displays fine (in the Grid Editor). However,
when I open it in the Player and start a new game, the board does not
display, no error trace is produced, but I get a large number of
messages on the console (most but I believe not all from line 314 in
Board,java):

I’d need to see the module to be able to offer any suggestions.


J.

Thus spake Tim M:

Error log sent

Thanks. You can see in the errorLog what’s not being closed: The stream
with hashCode() == 558582586 is still open when the IOException happens.
Now to determine why that’s so…


J.

Thus spake Joel Uckelman:

Thus spake Tim M:

Error log sent

Thanks. You can see in the errorLog what’s not being closed: The stream
with hashCode() == 558582586 is still open when the IOException happens.
Now to determine why that’s so…

Try svn7832. The TilingHandler wasn’t closing a DataArchive that it
opened. (This would never have been a problem in a language where
objects have destructors, as the DataArchive would have been closed when
the DataArchive went out of scope…)


J.

svn7832

Still having a saving problem. The “Save As…” seems to work just fine for me. It’s the “Save” that causes the problem. Error log attached.

The problem with map nt displaying depends on the zoom level - the map only displays (in the Player) when the zoom level is at 100%. I have reproduced this in three separate modules that I am working/playing with.

Has anyone else encountered this?

Haven’t gotten that far yet! :slight_smile:

-----Original Message-----
From: messages-bounces@vassalengine.org
[mailto:messages-bounces@vassalengine.org] On Behalf Of pgeerkens
Sent: Sunday, September 25, 2011 10:11 AM
To: messages@vassalengine.org
Subject: [messages] [Developers] Re: 3.2 builds

The problem with map nt displaying depends on the zoom level - the map
only displays (in the Player) when the zoom level is at 100%. I have
reproduced this in three separate modules that I am working/playing
with.

Has anyone else encountered this?


Read this topic online here:
https://forum.vassalengine.org/t/3-2-builds/4218/52

OK - I have deleted my image tiles, attempting to start over from a clean slate:
How does the Editor know when to tile an image? Can we add a button to the Board dialog titled “Re-time Image”? Can we put the tiles into the ZIp file so that one doesn’t so easily delete them?

Thus spake pgeerkens:

OK - I have deleted my image tiles, attempting to start over from a
clean slate:
How does the Editor know when to tile an image?

Are you asking about display or slicing?

The Editor doesn’t slice images. The process which slices tiles is
kicked off by the Module Manager, before the Editor or Player starts.
Because images can be added through the Editor which won’t be sliced
until the next time the module is loaded, there’s some code in Board
(lines 227-243) which checks whether the image to display has been tiled
already.

Can we add a button to the Board dialog titled “Re-time Image”?

Why would this be needed?

Can we put the tiles into the ZIp file so that one doesn’t so easily
delete them?

No, this creates a different problem, namely that modules would become
significantly larger, which would tax our site’s outgoing bandwidth too
much.


J.

Thus spake pgeerkens:

The problem with map nt displaying depends on the zoom level - the map
only displays (in the Player) when the zoom level is at 100%. I have
reproduced this in three separate modules that I am working/playing
with.

Has anyone else encountered this?

No, I haven’t seen this. What modules are they?


J.

I’ve uploaded a build which I think might fix the ZIP file writing problem. Please try this and post the errorLog if it fails. (Note that the errorLog might be quite large, due to the extra diagnostic output this build has.)

Thus spake Brent Easton:

Joel,
There is a fix in branch brent-3.2@7824 for a bug that Tim found.
Brent.

Got it.

Have you had a chance to look into the two issues I emailed you about
on the 12th?


J.

Ha! I have been runing everything in standalone mode to facilitiate debugging. Let me see what happens when I run from the MM

When I run from the Module Manager everything seems to work.

On a related topic: Have you looked at this implementation of a Zip-file modifier?
http://www.javaworld.com/javaworld/jw-10-2000/jw-1027-toolbox.html

Thus spake pgeerkens:

Ha! I have been runing everything in standalone mode to facilitiate
debugging. Let me see what happens when I run from the MM

Yeah, that might give you some tiling problems.


J.

Thus spake pgeerkens:

When I run from the Module Manager everything seems to work.

Good.

On a related topic: Have you looked at this implementation of a Zip-file
modifier?
javaworld.com/javaworld/jw-1 … olbox.html

Yes, I believe I looked at this one when I wrote ours. One reason why
I prefer ours is that it permits multiple simultaneous reads.


J.

Thus spake Brent Easton:

And brent-3.2@7825 adds a missing Help button to the Mass Piece Loader
(No help page written yet).

Merged to trunk@7835.

Someone need to make a list of the documentation we’re missing for 3.2.


J.

Thus spake soft-bug:

Just a feedback after launching the new 3.2 builds …

The font size used is __very small __… i have a good sight but it’s
now difficult to see small text, especially in editor mode.

The previous colored icons (editor mode) were blue/grey in the 3.1
series were neutral… now the yellow ones focus your attention on them
… and with these small texts (font size) is very difficult to find
something at a glance.

Could you post screenshots of both of these so we can get a clearer
idea of what you mean? (The text is not smaller for me.)


J.

Just ran the snv7833 Logged_8. So far, no problems. The mod properly saved itself.

Two questions:

  1. Are the images supposed to tile every time you open the module? It’s doing that here. I didn’t know if it was supposed to do that or if it’s supposed to be a one time thing unless the graphics change.

  2. Is there a math / expression engine it this one? If so, is there some documentation somewhere for using proper syntax for expressions?

Thus spake DrNostromo:

Just ran the snv7833 Logged_8. So far, no problems. The mod properly
saved itself.

Two questions:

  1. Are the images supposed to tile every time you open the module? It’s
    doing that here. I didn’t know if it was supposed to do that or if it’s
    supposed to be a one time thing unless the graphics change.

No, it’s supposed to happen the first time a module is opened, and
thereafter only when that module is modified.

  1. Is there a math / expression engine it this one? If so, is there some
    documentation somewhere for using proper syntax for expressions?

Yes, I believe so. There’s no documentation yet.


J.