RecursionLimiter currently erroneously limits call stack/depth, not recursion alone. Still waiting on Brent to gimme the green light to correct this.[/]
After RecursionLimiter is corrected, I wanna make TriggerAction handle animations (via separate threads)[/]
Trying to correct oddball Traits engine so newbies and veterans can use Traits in top-down, logical style/flow[/]
About oddball Traits engine, I just discovered this:
Variables (DynamicProperty or Marker) are, so to speak, “declared and put into scope top-down” (top one first, then 2nd and so on)[/]
Commands are executed bottom-up[/]
Are my assumptions correct? I haven’t checked the 2nd point about command-execution order.
Is it worth it for me to add a “Function” trait that lets module designers lay out variables and commands in logical (ala modern day programming) style? In the Funtion trait, I would attempt to use most/all existing library of Traits so that veterans find the Function trait familiar.
Or should I just start rewriting all existing Traits into Beanshell methods instead?
About Python for scripting, I feel that we can test out our translation of existing Traits into script methods/functions first, with Beanshell. It shouldn’t be too much effort to port to Python from Beanshell.
The Traits engine is unraveling my ability as a programmer! That is, after designing a module with the Traits engine for some time, I find myself unable to program anymore in Java! My logic and flow is all warped. My brain hurts like it’s been twisted inside out.
Brent Easton acknowledged reproducing the behavior described in the quote and logged it as Bug 4050. I don’t know if he intends to fix it for 3.2. I’d rate the issue as low-priority, though it can be annoying at times. (I originally reported this here: viewtopic.php?f=5&t=4499&start=30#p26040 )
I see this bug too! Yes, it is terribly annoying, and I would list it as broken. I’ll fix it within these couple of days. (I’ll commit my fixes the moment my end-of-line character issue is resolved or allayed at here).
The bug only occurs when the Windows native L&F is turned on, and I believe it is most likely a Java bug. The code involved is extemely complex with multiple layers of Listeners interacting accross multiple classes. I am glad you will have a fix for it in the next day or two Jon.
I am working on cleaning up and standardising the ‘board-bases’ editors (Deck/Stack Positioner, Irregular Grid region Editor, Zone Shape Editor), extracting duplicated code and fixing bugs. That’s pretty much it for me apart from looking at bugs and general issues raised.
It’s odd, because it appears to happen only with Brent’s account, and it
recurs almost immediately after I change the name associated with
Brent’s account it in the database. Fixing this will require looking at
the code in Bugzilla to see under what conditions the name can be reset.
If you’d like to do that, I’d appreciate it.
I’m good with reverse-engineering, which is why I kill bugs pretty quickly. But that’s all I do.
If you ask me to “just shut up and finish up your suggested Pandemic game polish”, which I believe (perhaps mistakenly) I can technically do, I’ll be procrastinating. I promised to redo Pandemic in 2 days, and never got around to it! For the record, I think I’ll take much longer than most of you guys to redo Pandemic.
So, feel free to throw bugs at me and tell me to “just shut up and eat bugs”! Heh. Yeah, I’m willing to take it upon myself to be responsible for bugs in Vassal, cos I can do that pretty easily. Rest of you guys should help me create games I can enjoy!
[size=150]Commander, dilithium chambers are at full. Warp cores stable and ready. Engineering is good to go! Sir![/size]
So, feel free to throw bugs at me and tell me to “just shut up and eat
bugs”! Heh. Yeah, I’m willing to take it upon myself to be
responsible for bugs in Vassal, cos I can do that pretty easily. Rest of
you guys should help me create games I can enjoy!
With your ‘fix’ in place, you can no longer drag counters from GamePiece palette and drop them on a map. They just dissappear.
This existing code works perfectly with Java L&F turned on, but is only broken with Windows L&F turned on. This is why I suspect a Java bug in the Windows L&F. There appears to be a difference between the Java and Windows LaF’s in the sequence of Mouse events generated when you cancel a popup window by clicking away from it.
This existing code works perfectly with Java L&F turned on, but is only
broken with Windows L&F turned on. This is why I suspect a Java bug in
the Windows L&F. There appears to be a difference between the Java and
Windows LaF’s in the sequence of Mouse events generated when you cancel
a popup window by clicking away from it.
This might be a reason to give up on the Windows L&F. That would also
solve our font size problem.
Sorry! Submitted a new patch. Didn’t cater for the case where pieces are dragged between different maps. Actually, they don’t disappear; they just don’t get moved or dragged! Note the function “isClicked”. The problem with my patch is right there.
I don’t know if this is a Java bug. The fixes I made are all logical fixes (to do with logic). In short, it indicates that the problem isn’t at a lower (API) level, but at a higher (programmer) level.
Thanks for testing!
I didn’t test if the patch works for Java L&F. Can you check if I broke things for the Java L&F?
Now, this would most likely be an API error. Is there a tracker for this, so I can observe this difference? Currently, I’ve added codes to work around this problem. I merely used the right-click pressed to “cancel drag” (on second thought, you might wanna change this logic to “buttonPressed != BUTTON1” instead, so that anything other than left-click press will cancel drag).
Erm. Is it alright if you give me a little support, say in terms of testing my patches, instead of telling me I shouldn’t have to do anything? Well, if I’m breaking things, please do tell me to stop. But otherwise, is it alright for the team to allow me some indulgence in fixing things?
I don’t see that NullPointerException. Check out trunk version 7945, apply my patches, and test. Thanks!
Since we have other issues with the Windows L&F, we are considering reverting to the Java L&F, which will fix this issue also, hence my comments. Please, keep at it. I will have a look at the latest version.