The Windows installer creates VASSALGameLog, VASSALModule, and VASSALSavedGame sub-keys named “DefualtIcon” instead of the expected “DefaultIcon”. Their string values are left empty as well.
There’s a fix for the key name typo here. It’s only been that way since 2008.
What do you think should be there as string values?
I would have said “M:\Program Files\VASSAL-3.7.23\VASSAL.exe,0” (using whatever the user’s install path may actually be) but it seems Explorer uses that icon by default anyway, so an empty value seems to work just fine.
Why hasn’t the key name typo been fixed in the installer itself? It should be a very simple edit of the installer’s production files.
Why do you think the key name typo hasn’t been fixed in the installer? Maybe I’m not seeing what you’re seeing. The PR linked above is for fixing the key name typo in the installer.
Because I ran the installer and then I looked at the registry. That’s how I spotted the typo.
Which installer do you mean, the one for 3.7.23? a test build for 3.7.24?
3.7.23 won’t change—it’s already been released.
The 3.7.23 installer. My expectation is that the typo will be fixed with the release of the next installer.
Yes, fixing the installer for the next release (3.7.24) was the purpose of the PR.