Beta 6 bug fixes

swampwallaby-work4@4598 finally fixes

Bug [2372199] NPE in PieceSlot.updateGpId()

I fixed the Place Marker trait last time, forgot about Replace.

B.

Thus spake “Brent Easton”:

Merged to trunk@4599.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

swampwallaby-work4@4644 has a fix for

Bug [2381419] NPE in RegionGrid.Config.EditRegionAction.windowClosed()

B.

Thus spake “Brent Easton”:

Merged to trunk@4645.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Swampwallaby-work5@4659 has fix for:

Bug [2418907] NPE When SendToLocation sends to Region that does not exist

It also adds additional debug information to many Bad Data Reports to make it easier to identify the component that is generating the error.

For Bad Data in Decorators, the name of the GamePiece and the name and type of the Decorator are included, plus a better presentation of the invalid data identifying the field containing the data.

For Bad Data in AbstractConfigurables, the name and type of the Configurable is included.

Images not found is a problem though - The File Not Found exception is completely handled within the Op implementation, which does not have any context to identify the component that is using it.

B.

Does this mean that whenever “Bad Data” pops up its dialog users/editors
will be able to identify exactly why/where/what it is, because the Bad Data
errors I’ll get do not generate a bug report - at least they haven’t,
although have solved / identified a few so far

Post generated using Mail2Forum (mail2forum.com)

That was my intention.

For example, if you try to Increment Dynamic property AAA by the value of marker BBB which contains the value ‘xyz’, you previously got the message:

Not a number: xyz

but now, you will get:

Numeric field contains a non-number: Increment AAA: format=$BBB$, value=xyz

instead.

Bad Data Errors never generate bug reports any more - they are problems in the module, not Vassal. However, Bad Data Errors do still write the details you see in the dialog/chat window, plus a stack trace into the ErrorLog, so if you get one, you can still find additional information in there.

B.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

The reason I did it that way was because I wanted to avoid having the same
boilerplate error handling code in a hundred different places. What do
you think we should do?


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

We don’t need anything too fancy, just some way of identifying which component ‘owns’ each image.

What about passing an String ID field to the various Op constructors that can be printed out in any error messages? It will be up to the calling components to format an appropriate ID. For an AbstractConfigurable, it would just need to be the name and type as displayed on the configureTree. For a trait, the GamePiece BasicName, trait type and trait description.

B.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

To get context, of course, you need to propagate the error the calling component. However, you can at least hide the error-reporting code in the Exception class, so that the calling component just has to, say, call ex.report(this) in the catch block.

rk

Post generated using Mail2Forum (mail2forum.com)

swampwallaby-work4@4667 contains fix for

Bug [2442887] Exception if no Layer levels and type new level name

B.


Brent Easton
Analyst/Programmer
University of Western Sydney
Email: b.easton@exemail.com.au


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

swampwallaby-work4@4668 contains fix for

Bug [2432774] ClassCastException: PrototypeDefinition$Config$Definer$Plain cannot be cast to VASSAL.counters.Decorator

B.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

Merged to trunk@4673.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

Merged to trunk@4674.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

swampwallaby-work4@4677 contains fix for

Bug [2415632] NPE in DeckGlobalKeyCommand.encode()

B.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

Merged to turnk@4678.

J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

swampwallaby-work5@4679 contains fix for

Bug [2418813] NPE Sending PrivateMsg to person who is 'Ignoring' you  

B.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

One outstanding fix for me:

swampwallaby-work@4679 has fix for

Bug [2418813] NPE Sending PrivateMsg to person who is ‘Ignoring’ you

I’m waiting for Rodney for fix for

Bug [2413649] Can’t change Global preferences

and I will then fix

Bug [2358673] Piece transparency in LOS looks weird at non 100% zoom

I have supplied Rodney with fixes for

Bug [2219448] Can Synchronize with players in Locked Rooms

who is reviewing them and integrating the server changes.

Joel, you have my ‘counting’ fix for

Bug [2265820] StackOverflowError in LaunchButton$1.actionPerformed()

Merry Chistmas all!

Brent.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

Merged to trunk@4687.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

swampwallaby-work5@4713 has a fix for

Bug [2476838] IllegalArgumentException in BundleHelper.getString()

Turns out this was caused by German and Netherlands translators translating the ‘General.date_display’ key from ‘{0,date}’ to ‘{0,datum}’. However, ‘date’ is a key used the Format class and must not be translated.

My fix just fixes the two translations and improves the error reporting if something similiar happens again.

A permanent fix is possible to hard-code the date_display as ‘{0,date}’ and not let it be translated. There is probably no need for it to be translatable as the {0,date} is localized to the local date format anyway.

B.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)