swampwallaby-work@4793 has fix for
Bug [2495248] NPE in Replace.replacePiece()
This turned out to be completely unrelated to previous NPE in Replace bugs. It was caused by the module trying to replace the same counter twice with the same key command. The second Replace found the counter no longer there.
The bug fix is to generate a Bad Data Report instead of the NPE.
B.
Thus spake “Brent Easton”:
Merged to trunk@4795.
Do you find the creation of BadDataReports cumbersome? Since we introduced
it, we’ve accumulated a bunch of methods the sole purpose of which seems
to be to wrap a call to ErrorDialog.dataError(new BadDataReport(…)).
There is literally not a single instance of ‘new BadDataReport’ which does
not occur as an argument of ErrorDialog.dataError(). That indicates to me
that the creation of BadDataReport should be pulled inside dataError().
Additionally, since dataError() doesn’t raise a dialog, I think it shouldn’t
live in ErrorDialog at all. Maybe we should create an independent class for
it, and call it DataError, an then have a report() method?
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Yes, sounds sensible.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Bug [2499980] User Profile display reverting to pre 3.1 version
Fixed in swampwallaby-merge@4806
B.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Bug [2497564] No GamePieceImage items when piece first created
Fixed in swampwallaby-work@4807
B.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Thus spake “Brent Easton”:
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Thus spake “Brent Easton”:
Merged to trunk@4812.
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Bug [2502717] NPE in PrefsEditor.save()
Fixed in swampwallaby-work@4819
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Bug [2499238] Return to Deck stacking issue
Fixed in swampwallaby-work@4823
B.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Bug [2503662] NPE if go online with a newly created module
Fixed in swampwallaby-work@4824
B.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
And the last for this evening:
Bug [2498607] Edit extension from another module generates bug report
Fixed in swampwallaby-work@4825
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Thus spake “Brent Easton”:
Merged to trunk@4828.
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Thus spake “Brent Easton”:
Merged to trunk@4829.
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Thus spake “Brent Easton”:
Merged to trunk@4830.
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Thus spake “Brent Easton”:
I’m going to hang onto this one until I revisit the CRC32 stuff.
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Bug [2431468] NumberFormatException in StackMetrics.setAttribute()
Fixed in swampwallaby-work2@4847
This was caused by hand editing of the buildfile and entering invalid values into the Stackmetrics. Instead if throwing an IllegalBuildException, Stackmetrics now catches the NumberFormatException, sets the attribute to the Default value and reports a DataError with the message:
Bad data in Preference [Stackmetrics]
At the point the Exception is caught, the module is still building and the owning map name is not known yet (since modules are built from the bottom up).
B.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Thus spake “Brent Easton”:
Merged to trunk@4856.
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)