beta4 - hang vassal in editor

consistent.
beta4.
may have happened in other versions, usually related to moving up/down below/above the can rotate trait in a list… but never said anything until now, sorry.

load the latest Strategos.vmod module (yes, that one again) from…
http://www.user.shentel.net/pmurphy/Strategos/Strategos.vmod
open it in the editor.
open the “Foreground Traits for all Units” prototype definition (properties).
select the “Trigger Action - Retreat” trait in the current traits list.
click the “move up” button.
vassal hangs at that point requiring the tender mercies of the task mangler.

this trigger action accepts a keyboard input and calls a move fixed distance trait, located whichever side of can rotate makes it work to reatreat, followed by a up arrow.

tested before adding the trigger action and it (without the up arrow) worked, so changed the key for retreat to be able to use the original cmd for the trigger and set it up, then when re-arranging in the list ran into this little problem.

Thanks,

I have replicated the problem and am looking into it now. Sourceforge bug #2202296

Regards,
B.

*********** REPLY SEPARATOR ***********

On 26/10/2008 at 8:56 PM IrishBouzouki wrote:


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

new vmod file has been uploaded with the problem already worked around Brent (et al) so save away the one you have to investigate it (although I would bet you could do a similar operation with another module and produce the same effects).

the release 3.0 version does not have the bug, and I simply used that version to perform the one operation then went back to editing in beta 4.

the beta 4 version does have the bug.

not sure about beta 3.

Thanks,

I have worked out what the problem is, it’s a strange one, and it was introduced into one of the 3.1 betas as part of a fix for another problem.

The problem is actually in the ‘Can Rotate’ trait that only occurs if you move the trait above a ‘Can Rotate’ up, and there are certain other traits above it.

Just sorting out a fix now,

B.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Joel,

Tracked this one down to FreeRotator.setInner() where it was creating a
GamePieceOp.

The state of the GamePiece inner/outer stack is not guaranteed
to be consistent within a setInner() call, however Op.piece()
assumes the inner/outer data is valid and enters an
infinite loop.

Specifically, when the PieceDefiner moves pieces up or down, a piece can
temporarily be its own grandfather.

I believe I have fixed it by having FreeRotator recreate the GamePieceOp lazily,
but could you have a close look at what I have done.

Also committed to swampwallaby-work are:

4357: Bug [2172904] NPE in StackMetrics.merge()
4356: Bug [2194826] ArithmeticException in HexGrid.HexGridEditor.check()

B.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Well, I may not know much, but I do recall there is a song about that…

Thus spake “Brent Easton”:

I don’t remember what I did now: Are these fixed in the trunk?

J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Brent will have to tell you why or how, but yes they are corrected in beta 5 it would seem, at least I have not experienced the same trouble since maybe some svn# between betas 4 & 5.

Joel,

All of these changes have been merged in.

B.

*********** REPLY SEPARATOR ***********

On 16/11/2008 at 11:16 PM Joel Uckelman wrote:


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)