Couldn't save module {0} - Bug:1860932

Brent_Easton · December 26, 2007, 11:43pm

I’m getting this all the time on XP.

For me, it seems to be related to adding new counter images into the module via the File Dialog. General editing does not cause me any problems.

Regards,
Brent.

*********** REPLY SEPARATOR ***********

On 26/12/2007 at 12:35 PM bsmith wrote:

Brent Easton
Analyst/Programmer
University of Western Sydney
Email: b.easton@uws.edu.au

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

tbyrne · December 26, 2007, 11:45pm

EVERY time I’ve ever seen this (and there have been a number) I have
found other instances of VASSAL running. Those instances were no
longer visible, but they were running. I think it would be useful if
when experiencing this problem, the process list gets checked to see
if there are other java instances running.

It could be less of a problem with writing the file, and more of a
problem with VASSAL completely closing. Just a suggestion based on my
experience.

On 12/26/07, Joel Uckelman uckelman@nomic.net wrote:

Thus spake “bsmith”:

I understand Joel is looking into the problem.

Out of curiosity, what operating system is everyone using? I’m on Windows Vi
sta myself.

Confirmed again yesterday that sometimes not even “Save As” works to fix this
error; In these cases the only resolution is to hope and pray that a temp.z
ip file still exists!

This is a difficult bug for me to troubleshoot, because it doesn’t occur
on my development box (Linux).

The first IOException in your errorLog probably happened because there
was an open file handle on the module file already. I’ve found many
places where we neglect to close streams, so this could be the result of
an unreferenced stream which was open on the module but not yet garbage
collected.

The second one could only happen if the module file no longer exists,
and I’m guessing that’s a consequence of the first exception.

In order for me to investigate this problem, I need more errorLogs
from people who have experienced this bug, and if possible, a reliable
way to trigger it.

–
J.

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Brent_Easton · December 27, 2007, 12:55am

Grab a copy of procexp.exe from

technet.microsoft.com/en-us/sysi … 96653.aspx

It is Task Manager on steroids and can tell you what process has a file open.

Regards,
Brent.

*********** REPLY SEPARATOR ***********

On 26/12/2007 at 5:45 PM Tim Byrne wrote:

EVERY time I’ve ever seen this (and there have been a number) I have
found other instances of VASSAL running. Those instances were no
longer visible, but they were running. I think it would be useful if
when experiencing this problem, the process list gets checked to see
if there are other java instances running.

It could be less of a problem with writing the file, and more of a
problem with VASSAL completely closing. Just a suggestion based on my
experience.

On 12/26/07, Joel Uckelman uckelman@nomic.net wrote:

Thus spake “bsmith”:

I understand Joel is looking into the problem.

Out of curiosity, what operating system is everyone using? I’m on

Windows Vi

sta myself.

Confirmed again yesterday that sometimes not even “Save As” works to

fix this

error; In these cases the only resolution is to hope and pray that a

temp.z

ip file still exists!

This is a difficult bug for me to troubleshoot, because it doesn’t occur
on my development box (Linux).

The first IOException in your errorLog probably happened because there
was an open file handle on the module file already. I’ve found many
places where we neglect to close streams, so this could be the result of
an unreferenced stream which was open on the module but not yet garbage
collected.

The second one could only happen if the module file no longer exists,
and I’m guessing that’s a consequence of the first exception.

In order for me to investigate this problem, I need more errorLogs
from people who have experienced this bug, and if possible, a reliable
way to trigger it.

–
J.

Messages mailing list
Messages@forums.vassalengine.org

http://forums.vassalengine.org/mailman/listinfo/messages_forums.vassalengine.org

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

–
No virus found in this incoming message.
Checked by AVG Free Edition.
Version: 7.5.516 / Virus Database: 269.17.9/1198 - Release Date: 26/12/2007 5:26 PM

Brent Easton
Analyst/Programmer
University of Western Sydney
Email: b.easton@uws.edu.au

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

tbyrne · December 27, 2007, 1:03am

Good call, That’s what I use. And every time, its been another java
process (specifically VASSAL) that has the file open.

On 12/26/07, Brent Easton b.easton@exemail.com.au wrote:

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

bsmith · December 27, 2007, 2:30am

Nice! I’m adding that to my list of must-have Windows tools, right up alongside Spacemonger and PowerGrep

uckelman · December 27, 2007, 10:59am

Thus spake “Tim Byrne”:

Why did you keep opening and closing VASSAL to work on the same file?

–
J.

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

bsmith · December 27, 2007, 11:17am

This is something I do a heck of a lot too. Quite often I like to make bulk changes to counter graphics, this may involve running a Photoshop Batch against 100 counters to clean them up/center images etc. So first I extract the module, modify the counters, re-zip the module then open it in Vassal to see how it all looks. After making some changes to the actual module, later on if I need to do more counter changes I need to repeat this process.

Another reason for opening and closing is I have VB scripts which do such things as import counters by parsing the buildFile (this is a Godsend!!), a script which takes counter names from a textfile and automatically names all of the counters in the module and sorts them alphabetically. These scripts mean I can churn out modules with hundreds of scanned counters in a couple of days. But it does involve lots of uncompressing and re-compressing of the module!

Hmmm, if only there was a way to open a module folder instead of a zip file.

Ben

uckelman · December 27, 2007, 3:33pm

I tracked down and fixed a lot of unclosed streams today. I think it’s
possible that you won’t see this bug in this build:

http://www.nomic.net/~uckelman/tmp/vassal/VASSAL-3.1.0-svn2766.zip

Please try it and let me know.

tbyrne · December 27, 2007, 3:44pm

I only do about 1/3 of my editing in Vassal. The other 1/3 is in vi.
The other 1/3 is using perl.

The buildfile is not only XML, as you know its XML plus a bunch of
secret sauce. I often test my changes right away to make sure I’m ok
the right track.

I keep my source in SVN. So when I add images, I add them to SVN, and
rebuild the module (the build module is pretty much the only think I
don’t keep on SVN). After making a bunch of changes in vassal I
extract the changes and often do a svndiff to better understand how
vassal does what I want under the hood.

Lastly, I have found instances when certain changes in the editor do
not take place until I restart vassal (not just the game) Of course
I’ve done a poor job of keeping track of that, so there are time when
I can’t get things working as I like and I just restart hoping its one
of those changes. Sometime it is.

On Dec 27, 2007, at 5:17 AM, “bsmith”
messages@forums.vassalengine.org wrote:

uckelman wrote:

Why did you keep opening and closing VASSAL to work on the same file?

This is something I do a heck of a lot too. Quite often I like to
make bulk changes to counter graphics, this may involve running a
Photoshop Batch against 100 counters to clean them up/center images
etc. So first I extract the module, modify the counters, re-zip the
module then open it in Vassal to see how it all looks. After making
some changes to the actual module, later on if I need to do more
counter changes I need to repeat this process.

Another reason for opening and closing is I have VB scripts which do
such things as import counters by parsing the buildFile (this is a
Godsend!!), a script which takes counter names from a textfile and
automatically names all of the counters in the module and sorts them
alphabetically. These scripts mean I can churn out modules with
hundreds of scanned counters in a couple of days. But it does
involve lots of uncompressing and re-compressing of the module!

Hmmm, if only there was a way to open a module folder instead of a
zip file.

Ben

Ben

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

uckelman · December 27, 2007, 11:31pm

Here’s another build, with even more unclosed streams now closed explicitly:

http://www.nomic.net/~uckelman/tmp/vassal/VASSAL-3.1.0-svn2770.zip

Try this and let me know if you still experience this bug.

bsmith · December 27, 2007, 11:35pm

Thanks Joel.

I downloaded and tested VASSAL-3.1.0-svn2766 with my Under the Lily Banners module. It still has trouble with rotated counters. I can change layers when the counter is unrotated, but when rotated it will not change layers; This is not a problem in 3.0.15.

So at the moment at least, it’s unplayable.

uckelman · December 27, 2007, 11:58pm

Thus spake “bsmith”:

I haven’t worked on that yet.

What I wanted you to test was the module-saving problem. Does that still
happen?

–
J.

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

bsmith · December 28, 2007, 1:57am

Ah ok, I thought maybe you had missed my earlier post. I’m not sure I can deliberately reproduce the fault (even in 3.0.15) but I’ll have a play around.

uckelman · December 29, 2007, 1:13am

Thus spake “bsmith”:

I backported my stream fixes to the 3.0 series. Try this build, and let me
know if you still have problems saving modules:

nomic.net/~uckelman/tmp/vass … vn2778.zip

(Also, if you find that I introduced any bugs by closing streams
overzealously, please report those as well.)

–
J.

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

uckelman · December 29, 2007, 1:55pm

I fixed a bug in the previous test build. There’s a new one here, svn2780:

http://www.nomic.net/~uckelman/tmp/vassal/VASSAL-3.0.16-svn2780.zip

Please try this and let me know whether it solves the problem.

uckelman · January 2, 2008, 2:52pm

Thus spake “bsmith”:

This would be a relatively simple modification, I think. It could be
done by altering ArchiveWriter, DataArchive, and maybe one other class.

–
J.

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)