I noticed you have dropped support in 3.2 for allowing modules to contain references to .gif images, but not specifying the suffix.
Was this intentional, or an oversight? I’m assuming an oversight since your comments in teh code talk about giving designers warning before dropping this ‘feature’.
I am starting a project now to clean up all references to these images in the current version of VSQL.
Unfortunately, VSQL being ancient, is chock full of references to suffixless gifs and there are countless saved games and startup files ‘out there’ with references to these images.
That was intentional. Having to check for extentionless GIFs makes the
image loading code needlessly complex. I was intending that we warn people
about this before releasing 3.2, though.
I didn’t realize this would affect saved games as well as modules. I thought
we’d mostly solve the problem by fixing the old modules.
That would be a more complex version of the thing I was trying to eliminate.
How about having a converter instead? That way we could encapsulate all of
the old grotty stuff we want to get rid of, rather than have it strewn
throughout the codebase? I expect that we’ll have more things like this as
time goes on, so having a single place to put them all would be convenient.
I’m doing something like this with the preferences right now. There’s a
class which reads the old preferences format and writes the new one.
Save files include the type and state of all counters on the board. The image names for any images references by any trait are stored in the save file. Fixing the old modules will fix the non-trait images - Toolbar button images, etc.
The problem is that designers will not get a chance to fix their modules. I am fairly sure this is only an issue with very mdules. I am not even sure if modules other than VSQL have a problem. VASL perhaps.
A stand-alone converter, or something that runs automatically?
It’s intended to run automatically. If the preferences loader sees that
there’s no new-style preferences file but there is an old-style one, then
it will try to convert the old one.