Thus spake Cattlesquat:
It’s very app-dependent and situation-dependent. Like Notepad trying to
save a file on top of one that’s already open says “The process cannot
access the file because it is being used by another process.”. Whereas
if you’re in the “file explorer” (i.e. a folder) and have a copied file
in your clipboard and try to paste on top of an existing file of the
same name it will add " - Copy" to the end of the filename, and after
that it goes to " - Copy(2)" etc.
Hmm. That’s disappointing. I’d thought there’d be a standard way.
Will do. I’m assuming that getting this particular situation back to
displaying our traditional file-write problem dialog is already being
handled separately, unless you let me know you want me to open one for
that too.
That dialog display bug is one which is (a) old, (b) almost for sure has
at least one ticket open already, and (c) I think isn’t our bug. The
ticket will probalby have the name of the function where the NPE happened
in it.
Go find it and post a link here?
–
J.
I think it’s this bug: vassalengine.org/tracker/sho … gi?id=4159
It’s a bug in MigLayout. I fixed this problem in 2012 and sent them a patch. (See the commit message for c23c4c13.) In that commit, I added a modified miglayout-swing JAR, containing my patch… I wonder if that JAR got blown away… yes, yes, I think it did when we switched to using Maven.
So that’s the problem—pulling the unpatched miglayout-swing-4.2.jar via maven reintroduced the bug.
The link in my commit message to my MigLayout forum post (and whole forum, apparently) is dead, but fortunately I still have the patches. I’m not sure what the best approach is here—I’d assumed that they had merged my patch, but apparently they kicked the bucket before they got to it.
I wonder if anyone else picked up development?
This looks like the current (?) git repo: github.com/mikaelgrev/miglayout
I guess 13205 can represent “re-fixing that”. I will add a reference to your above messages.
That repo did pick up my patch. Looks like there is a 5.1 release.
Please try vassalengine.org/~uckelman/t … ows-64.exe in the situation where the file being saved isn’t writable. This build includes a miglayout-swing JAR new enough to include the patch I contributed to them, so you should not see a bug dialog with it.
Here is what I see. [attachment=1]Annotation 2020-07-24 062944.png[/attachment]
Good, that fixed the dialog display bug. Thanks for trying the test build.
I’m merging PR #116 now that we’ve confirmed it fixes that problem.