Error: Unimplemented binary String operator

Hello,

Flaney here;

Under VASSAL 3.2.0-svn8258, my trigger condition {(HangerBay & 32)==32} throws the error in the Subject line.

Have the newest builds dropped the use of binary string Ops? Please check and re-implement if possible. These have simplified a good chunk of code logic that was causing me to want to pull the hair out :angry:. It’s been working through svn-8232.

Thanks

Hi Flaney,

I assume you mean the bitwise and & and or |? Support for these operators is unchanged. I just ran a small test module that had no problem.

Are you sure it worked at 8232? The only change that could possibly affect it went in at 8229.

Are you able to check the value of HangarBay?

Can you provide a link to the module and a log file that demonstrates the problem?

Thanks.

Oops! :blush:

I was clicking the unit in question from the piece window as displayed before a New Game is started.

However, I use global variables to transfer data between interacting pieces and now find that this process is quite slow and often leads to …

Is this an effect of changes to Global variables?

Also, for this module, the first piece dropped on to the main window throws an Bug Error with these details:

2012-08-05 18:30:34,078 [0-main] INFO VASSAL.launch.StartUp - Starting 2012-08-05 18:30:34,093 [0-main] INFO VASSAL.launch.StartUp - OS Windows XP 2012-08-05 18:30:34,093 [0-main] INFO VASSAL.launch.StartUp - Java version 1.6.0_33 2012-08-05 18:30:34,093 [0-main] INFO VASSAL.launch.StartUp - VASSAL version 3.2.0-svn8258 2012-08-05 18:30:34,234 [0-AWT-EventQueue-0] INFO VASSAL.launch.ModuleManager - Manager 2012-08-05 18:30:43,406 [0-SwingWorker-pool-18739556-thread-1] INFO VASSAL.launch.AbstractLaunchAction - Loading module file C:\PROJECTS\Vassal\module\CGS_Babylon5+.vmod 2012-08-05 18:30:43,937 [0-SwingWorker-pool-18739556-thread-1] INFO VASSAL.launch.TilingHandler - No images to tile. 2012-08-05 18:30:43,937 [0-SwingWorker-pool-18739556-thread-1] INFO VASSAL.launch.AbstractLaunchAction - Loading module CGS-Babylon5 2012-08-05 18:30:43,953 [0-SwingWorker-pool-18739556-thread-1] INFO VASSAL.tools.io.ProcessLauncher - launching C:\Program Files\Java\jre6\bin\java -Xms256M -Xmx512M -DVASSAL.id=1 -DVASSAL.port=1206 -Duser.home=C:\Documents and Settings\Flane -cp lib\Vengine.jar VASSAL.launch.Editor --edit -- C:\PROJECTS\Vassal\module\CGS_Babylon5+.vmod 2012-08-05 18:30:44,843 [1-main] INFO VASSAL.launch.StartUp - Starting 2012-08-05 18:30:44,859 [1-main] INFO VASSAL.launch.StartUp - OS Windows XP 2012-08-05 18:30:44,859 [1-main] INFO VASSAL.launch.StartUp - Java version 1.6.0_33 2012-08-05 18:30:44,859 [1-main] INFO VASSAL.launch.StartUp - VASSAL version 3.2.0-svn8258 2012-08-05 18:30:44,859 [1-main] INFO VASSAL.launch.Launcher - Editor 2012-08-05 18:30:48,265 [1-AWT-EventQueue-0] WARN VASSAL.launch.BasicModule - CGS-Babylon5 version 1.6 2012-08-05 18:31:27,437 [1-AWT-EventQueue-0] INFO VASSAL.script.ExpressionInterpreter - Attempting to load /VASSAL/script/init_expression.bsh URI generated=jar:file:/C:/Program%20Files/VASSAL-3.2.0-svn8258/lib/Vengine.jar!/VASSAL/script/init_expression.bsh 2012-08-05 18:31:27,875 [1-AWT-EventQueue-0] ERROR VASSAL.tools.ErrorDialog - java.lang.StackOverflowError: null at java.lang.AbstractStringBuilder.append(Unknown Source) ~[na:1.6.0_33] at java.lang.StringBuilder.append(Unknown Source) ~[na:1.6.0_33] at VASSAL.tools.SequenceEncoder.appendEscapedString(SequenceEncoder.java:149) ~[Vengine.jar:na] at VASSAL.tools.SequenceEncoder.append(SequenceEncoder.java:88) ~[Vengine.jar:na] at VASSAL.counters.Marker.myGetType(Marker.java:138) ~[Vengine.jar:na] at VASSAL.counters.Decorator.getType(Decorator.java:216) ~[Vengine.jar:na] at VASSAL.counters.Decorator.getType(Decorator.java:217) ~[Vengine.jar:na] at VASSAL.counters.Decorator.getType(Decorator.java:217) ~[Vengine.jar:na] at VASSAL.counters.Decorator.getType(Decorator.java:217) ~[Vengine.jar:na] at VASSAL.counters.Decorator.getType(Decorator.java:217) ~[Vengine.jar:na] at VASSAL.counters.Decorator.getType(Decorator.java:217) ~[Vengine.jar:na] at VASSAL.counters.Decorator.getType(Decorator.java:217) ~[Vengine.jar:na] at VASSAL.counters.Decorator.getType(Decorator.java:217) ~[Vengine.jar:na] at VASSAL.counters.Decorator.getType(Decorator.java:217) ~[Vengine.jar:na] at VASSAL.counters.Decorator.getType(Decorator.java:217) ~[Vengine.jar:na] at VASSAL.build.module.BasicCommandEncoder.encode(BasicCommandEncoder.java:458) ~[Vengine.jar:na] at VASSAL.launch.BasicModule.encodeSubCommand(BasicModule.java:263) ~[Vengine.jar:na] at VASSAL.launch.BasicModule.encode(BasicModule.java:244) ~[Vengine.jar:na] at VASSAL.launch.BasicModule.encode(BasicModule.java:250) ~[Vengine.jar:na] . . . at VASSAL.launch.BasicModule.encode(BasicModule.java:250) ~[Vengine.jar:na]

Thanks and sorry

Flaney

Hi,
Could you please try one of the builds from 8242-8251 and see if that makes a difference? Just trying to pin down which change is causing the problem.
Thanks,
Brent.

Also,
A link to the module would be helpful,
thanks,
Brent.

I am debugging through each of the new builds to see where and when the Errors start appearing. Will update when I have more info…

Thanks

Flaney

Thanks, that will help a lot.
B.

My Errors have vanished with Build svn8268.

Thanks for the update!

I have also managed to fix the originally reported problem of ‘Error: Unimplemented binary String operator’ when you open a piece in the editor, or click on it in the game palette. Should be in the next build.

Thus spake Brent Easton:

I have also managed to fix the originally reported problem of ‘Error:
Unimplemented binary String operator’ when you open a piece in the
editor, or click on it in the game palette. Should be in the next build.

Merged to turnk@8273. Try 3.2.0-svn8273.

Brent, will converting null String references to 0 have any unintended
consequences for expressions users enter?


J.

On 15/08/2012 5:42 AM, Joel Uckelman wrote:

Thus spake Brent Easton:

I have also managed to fix the originally reported problem of ‘Error:
Unimplemented binary String operator’ when you open a piece in the
editor, or click on it in the game palette. Should be in the next build.

Merged to turnk@8273. Try 3.2.0-svn8273.

Brent, will converting null String references to 0 have any unintended
consequences for expressions users enter?

Joel,
I don’t believe so. The conversion of null string to 0 only happens at
the very last moment in the evaluaton of an expression, and only in the
case of a number and “”.


Brent Easton
Analyst/Programmer
University of Western Sydney
Email: b.easton@exemail.com.au