What is the appropriate response to file-format errors in the code? On the one hand, we don’t really want to have bug reports submitted for obviously corrupted files (I have a case like this on the bug tracker). On the other hand, there could be something wrong with the VASSAL code – this is particularly true for the ADC importer.
Right now I need a good way to deal with a bad Unicode sequence. What’s the right thing to do?
Thus spake “mkiefte”:
I would use ErrorDialog.show() to throw up an error message in cases where
you’re reasonably certain that an error is not a result of a bug in VASSAL.
A bad Unicode sequence is something which I think we can verify is not
our fault, yes? In that case, I’d use ErrorDialog.show().
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
It turns out that SavedGameUpdaterDialog already had a method for dealing with this. It’s probably fine, but you can change it. Superficially, it’s not any different than what you suggest.
2187303 is now fixed in SVN r4601.
Post generated using Mail2Forum (mail2forum.com)
Thus spake “Michael Kiefte”:
Merged to trunk@4613.
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)