Fine under 3.2.13, guaranteed crash under 3.2.14

Any ideas as to what kind of things might have broken under 3.2.14 that were working fine in 3.2.13?

I know you all need more specifics to really help me out, and I’ll probably have to go through the laborious processes of stripping out and adding in bits of my module until I pin down the cause, but what I’m really hoping for right now is a brief summary of what the update notes for 3.2.14 mean. What kind of functions have been altered. Those update notes are way over my head.

Briefly, my module crashes when trying to implement a single-click series of processes that usually takes a good few seconds to grind through, in which a few pieces are delected, a lot of decks are shuffled, and a piece layer is changed. I’m guessing it’s the shuffling?

Sorry for the useless post. Crying baby and work means I’m a bit rushed.

I also get a crash when shuffling a deck in a module that worked fine in 3.2.13.

The crash can be reproduced in a new module with only one deck with “re-shuffle via right-click menu” enabled.

java.lang.NullPointerException: null at VASSAL.counters.Stack.insertChild(Stack.java:207) ~[Vengine.jar:na] at VASSAL.counters.Deck.setContents(Deck.java:819) ~[Vengine.jar:na] at VASSAL.counters.Deck.shuffle(Deck.java:758) ~[Vengine.jar:na] at VASSAL.counters.Deck$6.actionPerformed(Deck.java:1040) ~[Vengine.jar:na] at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1995) ~[na:1.6.0_26]

The bug was simple enough for me, I found it!
Patch submitted in http://www.vassalengine.org/tracker/show_bug.cgi?id=11769

Thus spake downs:

The bug was simple enough for me, I found it!
Patch submitted in
vassalengine.org/tracker/sho … i?id=11769

Thanks for the patch. Try 3.2.15-svn9174:

vassalengine.sourceforge.net/builds/


J.

Thus spake downs:

I also get a crash when shuffling a deck in a module that worked fine in
3.2.13.

The crash can be reproduced in a new module with only one deck with
“re-shuffle via right-click menu” enabled.

Code:
java.lang.NullPointerException: null
at VASSAL.counters.Stack.insertChild(Stack.java:207) ~[Vengine.jar:na]
at VASSAL.counters.Deck.setContents(Deck.java:819) ~[Vengine.jar:na]
at VASSAL.counters.Deck.shuffle(Deck.java:758) ~[Vengine.jar:na]
at VASSAL.counters.Deck$6.actionPerformed(Deck.java:1040)
~[Vengine.jar:na]
at
javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1995)
~[na:1.6.0_26]

Try 3.2.15-svn9174:

vassalengine.sourceforge.net/builds/


J.

Same problem. Sometimes it crashes when I just right-click shuffle-able deck. Rolled back to 3.2.13, waiting for fix.

Thus spake SagePtr:

Same problem. Sometimes it crashes when I just right-click shuffle-able
deck. Rolled back to 3.2.13, waiting for fix.

Are you saying that 3.2.15-svn9174 has the same problem for you, or that
3.2.14 does?


J.

3.2.15-svn9174 seems to be OK. I hope bug is fixed.

No more crash for me.

Thanks for doing the leg-work downs.

My leisure (but I was interested too :wink: