Importer fix

Can you merge 3082 into the trunk. It fixes ImportAction now that things have been moved around. It wasn’t setting up the editor properly.

Also can I request the “Import Module” be placed under the “Tools” menu of the main program? It’s not obvious that “Import Module” is related to the editor to a newb.

  • M.

Thus spake “mkiefte”:

Done, in trunk@3083.

Was there a reason that I’m not seeing for changing

PlayerWindow.getInstance().setVisible(true);

to

module.getFrame().setVisible(true);

? Right now, those do the same thing, but calling PlayerWindow to get
its singleton strikes me as clearer.

Hmm. I’m not sure I agree with that. It goes against common application
design practice. “Import” is under the File menu in almost all apps I
see which have such a thing.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

I didn’t know that. I was just copying the behaviour or
EditModuleAction.loadModule(File).

Sounds good.

Then perhaps it should go under the File menu of the main Window.
Again the reason is that this capability is not obvious unless you’ve
opened the editor window.

The ADC2 modules are completely playable even if you don’t change
anything in the editor. You could just save after importing and
they’re fine.

  • M.

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

I’ve got a newb question, what does Import Module do? That wording doesn’t imply any obvious behaviour to me. Does it merge a module with one I may have open? Am I creating a new module and using an existing one as a template? Or does it just open a module?

A utility Mike wrote for importing Aide de Camp modules

Post generated using Mail2Forum (mail2forum.com)

Can we call it “Import ADC Module”?

Does anyone have a recent build so I can have a look at things and have a whine? :smiley:

A better approach would be to call the menu item ‘Import…’ and have it open a sub-menu with ‘ADC Module’ and (later) ‘Cyberboard gamebox’.

Brent.

*********** REPLY SEPARATOR ***********

On 15/02/2008 at 3:58 PM bsmith wrote:


Brent Easton
Analyst/Programmer
University of Western Sydney
Email: b.easton@uws.edu.au


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

It probably should be “Import module …” (with an elipses at the end).

Import usually means open a foreign file format – such as
comma-delimited tables into a spreadsheet application. In this case
it means open a module created by another program. Right now, it is
only capable of opening ADC2 modules. In the future, it will likely
open Cyberboard modules as well. It emulates the behaviour of other
programs in that, when the open file dialog opens, there is a
drop-down box from which you may select the type of file you wish to
import. As it stands, you can open a complete ADC2 module, just the
map, or just the counters.

It then loads the module and opens the editor. I had to make a lot of
assumptions regarding default behaviour for things that do not
translate well into VASSAL, but everything can be changed in the
editor. If you do nothing, the import results in a playable module
once you save.

A couple of major things have not yet been implemented: there are no
cards, for the simple reason that I’ve never played a module that used
cards. If there were only an ADC2 module for Combat Commander, that
would change, but there you go. Turn names are not implemented
either. These will be completed at some point. Then there are the
things that just don’t exist in VASSAL – terrain (although I
understand Brent is working on that) is not implemented. Then there’s
things that were just plain hard to do – counter values didn’t get
implemented because of the way those things are stored in VASSAL. It
can be done, but I never got to it.

And someday, I’ll document this. It was a tonne of work done in a
very short period of time. It’s amazing that it works at all.

  • M.

On 15/02/2008, Brent Easton b.easton@exemail.com.au wrote:


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Joel posted a link to a recent development release in this message:

vassalengine.org/forums/viewtopi … 4&start=17

  • M.

On 15/02/2008, bsmith messages@forums.vassalengine.org wrote:


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

There is a ADC mod for CC but then, there is already a vassal mod for it too (it too already has an early build of the terrain stuff Brent is working on). Both at GMT.

That would be painful.

When I made my comment about CC, I just couldn’t imagine that an ADC2
module for CC could possible exist, so i meant it kind of
tongue-in-cheek.

  • M.

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “bsmith”:

It can only import ADC2 modules right now. Other kinds of modules
will follow, so it should have a general name.

nomic.net/~uckelman/tmp/vassal/


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Michael Kiefte”:

I’ve made that change.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

I think it should show what it can import via the file filter in the
file chooser which will be displayed. That’s pretty common behavior.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)