Joel,
I have coded a fix in Brent-3.2-p2p@8701. Very simple, but should do the trick.
Thus spake Brent Easton:
Joel,
I have coded a fix in Brent-3.2-p2p@8701. Very simple, but should do the
trick.
Merged to trunk@8702. Try 3.2.6-svn8703:
vassalengine.sourceforge.net/builds/
–
J.
Using version 3.2.6-svn8703, there is a slight speed increase but nowhere near the speed increase that occurs when I uncheck the “Underneath when highlighted?” option.
Ok, found it.
When Underneath when Selected is ticked, the underlying piece is being drawn twice each time the counter is redrawn. Once before the ‘Underneath’ layer and again after it if the Underneath option is selected. Fixing this seems to have removed the lag altogether.
Fix committed to svn 8704.
Thus spake Brent Easton:
Ok, found it.
When Underneath when Selected is ticked, the underlying piece is being
drawn twice each time the counter is redrawn. Once before the
‘Underneath’ layer and again after it if the Underneath option is
selected. Fixing this seems to have removed the lag altogether.Fix committed to svn 8704.
Merged to 8707. Try 3.2.6-svn8707:
vassalengine.sourceforge.net/builds/
–
J.
Tested using Vassal 3.2.6-svn8712. Brent is correct, there is no longer any noticeable lag.
However a new bug seems to have crept in. In the Battlelore module, when selecting a unit, some layers disappear (banner and weapon layers). This occurs only for the foot units, not the mounted units. I’m not sure why this would be the case as the layers are identical between the 2 types of units.
Hmm,
I wasn’t sure if there might be some side effect of the change I made. I will have a look.
Ok, found the problem. Fix committed to svn 8713.
That should do it. If this works, it would be good to release 3.2.6 asap Joel, as 3.2.5 has a bug affecting modules with layers following properties with spaces in the name.
Thus spake Brent Easton:
Ok, found the problem. Fix committed to svn 8713.
That should do it. If this works, it would be good to release 3.2.6 asap
Joel, as 3.2.5 has a bug affecting modules with layers following
properties with spaces in the name.
Merged to trunk@8714. Give 3.2.6-svn8714 a try:
vassalengine.sourceforge.net/builds/
We can release 3.2.6 once we know this fixes the problem.
–
J.
I can confirm that the layer and lag issue is fixed using Vassal 3.2.6-svn8714.
Thus spake LB:
I can confirm that the layer and lag issue is fixed using Vassal
3.2.6-svn8714.
Thanks for checking.
Brent, should I release 8714 as 3.2.6 now, or is there more you’d like
me to wait for?
–
J.
Joel,
Because of the bug on 3.2.5, it will be best to get 3.2.6 out asap. I don’t have anything else coming up that can’t wait.
Thus spake Brent Easton:
Joel,
Because of the bug on 3.2.5, it will be best to get 3.2.6 out asap. I
don’t have anything else coming up that can’t wait.
Ok, I’ll put 3.2.6 out tomorrow.
–
J.