Log file prompting - Bug:1860941

You are playing back a PBEM log and simultanously recording a new log. When you reach the end of playback, the dialog box still appears asking if you would like to start a new log.

First, this dialog should not appear if you are already recording.
Second, and most important, if you accidentally choose to start a new log, it blows away the one you had already started!! So if you had spent 20 minutes doing your PBEM turn, you have just lost it all. I’ve had this happen and it isn’t a pretty sight, is this being worked on?

cheers

Ben

I have committed a fix for this bug to swampwallaby-merge@2854.

Joel, could you please merge this into your latest build?

Thanks,
Brent.

Thanks Brent, nice.

Ben, my builds from 2825 onward incorporate Brent’s fix.

nomic.net/~uckelman/tmp/vass … vn2858.zip

I’ve tried it myself and I think it works. My only concern is about the
wording of the Preferences associated with logging, in particular

“Prompt to start new Log File after a Replay?”

because that isn’t really what it means now. Instead it’s something like

"Prompt to start new Log File after a Replay if not already logging?

so we should change that. Any suggestions for better wording?

On Jan 18, 2008, at 12:49 PM, uckelman wrote:

First of all change “Prompt” to “Ask”. Less geeky, since this is for
ordinary users, not computer professionals.

“Ask to start new Log File after a Replay (unless already logging)”


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Do we really need “if not already logging” given that starting a new log file is impossible if you’re already logging?

rk

Post generated using Mail2Forum (mail2forum.com)

I agree. I think people will get the idea without it being unneccesarily wordy.

*********** REPLY SEPARATOR ***********

On 18/01/2008 at 1:44 PM Rodney Kinney wrote:

____________________________________________________________

Brent Easton
Analyst/Programmer
University of Western Sydney
Email: b.easton@uws.edu.au (b.easton@uws.edu.au)

Post generated using Mail2Forum (mail2forum.com)

On Jan 18, 2008, at 1:44 PM, Rodney Kinney wrote:

I would argue that it is needed.

Users and module designers who may be setting this preference might
not otherwise know that the new log file will only happen if logging
is not currently occurring. They might otherwise get the mistaken
impression that setting this preference will mean always asking to
start a new logfile, presumably closing any existing ones.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake Thomas Russ:

The reason it bothers me is that it’s now literally false, and there’s
no indication that you should read it as being elliptical for anything
else.

What about “Prompt to ensure logging after replay?” This doesn’t imply
(incorrectly) that a new log will begin if one is already going.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

On Jan 18, 2008, at 3:11 PM, Joel Uckelman wrote:

I think that is another option I had considered.

It’s fine, with the slight substitution of “Ask” for “Prompt”.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

I definitely like that better.

rk

Post generated using Mail2Forum (mail2forum.com)