Merge me Elmo

I made a small modification to VASSAL/chat/ui/ServerStatusView.java to append the number of players to each room name in the Server Status window. I like to surf the games in progress and this will help ignore those rooms with only a single player!

Image attached…

By the way how does this get into the next build; Do I just Commit the change to the trunk or is this done by Joel? Or is there a feature freeze on the Beta?

Commit it to your own branch and let Joel merge it to trunk. I’ll leave it to his discretion whether to impose feature freeze in this case.

rk

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Rodney Kinney”:

This is a pretty minor change. So long as nothing reads those strings
back and expects them to have a certain form (Rodney, can you confirm
they’re just for display?), then I’ll commit it.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Yep. They’re only used in the status window for display.

rk

Post generated using Mail2Forum (mail2forum.com)

I wanted to do it for the module names too, but that wasn’t nearly as easy or risk-free.

On Wed, Oct 22, 2008 at 8:40 AM, Rodney Kinney <rodneykinney@comcast.net (rodneykinney@comcast.net)> wrote:

Post generated using Mail2Forum (mail2forum.com)

Thus spake “bsmith”:

I want to merge this, but I don’t know what changesets to merge.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Don’t worry about merging it Joel, I’m still playing around. I think it’s better to do it properly rather than screwing with the module name directly. Let me work on it some more.

cheers

Thus spake “bsmith”:

Ok. Let me know when you’re ready.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Hey Joel.

Attached is a patch for showing the number of players in each module/room. Feel free to put this in the next Beta.

cheers