Preparation for 3.3.1 bug fix release

I’d like to release 3.3.1 with fixes for the following bugs, over 3.3.0:

  • 13083: BrowserSupport cannot open URLs on Linux without gtk3
  • 13111: IncompatibleClassChangeError due to change of ComponentSplitter methods to static

We’ve had quite a few reports of Bug 13111 so far, which was something I caused by not realizing that making non-static member functions static breaks binary compatibility, and it’s a blocker for opening some modules. (It turns out that there are a dismaying number of modules which use ComponentSplitter directly, which I’d also not known, but wouldn’t have mattered had the change to static been binary-compatible like I’d expected.)

The VASSAL-3.3.0-3-g428ea1d1 test build contains these changes:

vassalengine.org/~uckelman/tmp/

Note that this pushes the likely version for changes currently on master to 3.3.2.

I am sorry to report I am not seeing the pdfs. Not getting any error message either. This is what I get with 3.3.0.

The good news is I am not seeing the incomplete deal issue.

EDIT: Actually I think I could find your build and tested something else. Sorry.

Thus spake slimy:

I am sorry to report I am not seeing the pdfs. Not getting any error
message either. This is what I get with 3.3.1.

I don’t understand. There’s only one commit for that fix and I can
see it on the release-3.3.1 branch. Are you sure you tested the right
thing?

The good news is I am not seeing the incomplete deal issue.

You wouldn’t, because the test build is over the release branch, which
never had the commit which introduced the bug.


J.

I had tested the wrong one. I had been expecting it to be a 3.3.1-something.

Now I got the correct file. it is indeed working.

I’ve had confirmation from at least one of the bug reporters that the problem is fixed for them, so I’ll see about releasing 3.3.1 this evening.