problems with the VSQL module

We’ve had a lot of bug reports due to problems with custom code in the VSQL
module. Who’s responsible for that module?

The first two bugs here are due to using deprecated methods in DataArchive
for scaling:

sourceforge.net/tracker/?func=d … tid=594232

sourceforge.net/tracker/index.p … tid=594232

The only correct way to do scaling now is via Op.scale(). No other way will
work properly.

The third one is (probably) due to a bad custom ImageOp implementation in the
VSQL module:

sourceforge.net/tracker/?func=d … tid=594232

The fourth one is due to a missing image.

sourceforge.net/tracker/?func=d … tid=594232

I’d very much like to get these resolved, as I’m sick of dealing with bug
reports from this module.

Hi Joel,

I’m responsible for maintaining the custom code. I was not aware there where any current problems with the module, you should have mentioned earlier. You have been removing the duplicates and moving them to support reuests so quickly I hadn’t noticed them.

I will look into all of these.

A side issue is that I seem to have no access to the Support Requests section of sourceforge. I cannot move reports to or from that section, or manipulate them in any way.

Cheers,
Brent.

On 26/04/2009 at 3:44 PM uckelman wrote:


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

Sorry about that. I hadn’t realized this was yours.

I’d been stockpiling all of these module problems under Suppor Requests
for the day when we start going through the module library to determine
compatibility. Because it’s taken a lot longer to get to that point than
I expected, I’m starting to bug people about these problems.

It seems that you’d never been granted permission. Try now.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Joel,

I believe I have found and fixed the problems in the VSQL module. I’ve pass the new version on to the module coordinator, it should start making its way out to players soon. The new version number is ‘4.1 beta 7.59’ (not my numbering scheme). Let me know if you see any more issues with this version.

B.

On 27/04/2009 at 10:34 AM Joel Uckelman wrote:


Brent Easton
Analyst/Programmer
University of Western Sydney
Email: b.easton@exemail.com.au


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

Great. Thank you.

Now, if we could just get VASL fixed so that it works with 3.1, that would
reduce the module bugs we see to a trickle…

As for the remaining module bugs:

  • The Euphrat & Tigris module has the most. I’ve emailed the maintainer
    listed on the site about this one.

  • Some module bugs listed there are likely to be out-of-date. It would
    be great if somebody (I’m not suggesting that you do it—somebody who’s
    not writing code would be idea for this) would go through these and
    determine which of these modules have since been fixed, and which still
    have the problems reported.

  • Once we know which modules still have problems, then we can start asking
    their maintainers to fix those modules.

I was planning to get a project going to do this once we have the module
pages up on the new site, but there’s no particularly good reason to wait
for that—I think we should do this now.

Can I get a vounteer to start in on this?


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

I can

From: Joel Uckelman uckelman@nomic.net
To: VASSAL Engine Forums Mailing List messages@forums.vassalengine.org
Sent: Monday, April 27, 2009 8:43:21 AM
Subject: Re: [Module Support]problems with the VSQL module

Thus spake “Brent Easton”:

Great. Thank you.

Now, if we could just get VASL fixed so that it works with 3.1, that would
reduce the module bugs we see to a trickle…

As for the remaining module bugs:

  • The Euphrat & Tigris module has the most. I’ve emailed the maintainer
    listed on the site about this one.

  • Some module bugs listed there are likely to be out-of-date. It would
    be great if somebody (I’m not suggesting that you do it—somebody who’s
    not writing code would be idea for this) would go through these and
    determine which of these modules have since been fixed, and which still
    have the problems reported.

  • Once we know which modules still have problems, then we can start asking
    their maintainers to fix those modules.

I was planning to get a project going to do this once we have the module
pages up on the new site, but there’s no particularly good reason to wait
for that—I think we should do this now.

Can I get a vounteer to start in on this?


J.


Messages mailing list
Messages@forums.vassalengine.org (Messages@forums.vassalengine.org)
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake Timothy Mccarron:

That would be great. Here’s what I suggest doing:

  • If the report is no longer current:
  • Close it.
  • If there’s contact info, email the person who reported the bug to let
    him know that there’s a new version of the module available.
  • If the report is current:
  • Figure out, if possible, who the module maintainer is, and email the
    maintainer letting him know that his module is broken, and that if he
    has questions about how to fix it, he should ask in the forum here.
    Leave a note in the bug report that the maintainer has been emailed.

  • If you can’t figure out who the maintainer is, leave a note in the bug
    report to that effect. At some point in the near future, we’ll put out
    a call for recruiting maintainers for unmaintained modules.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Ok,

Joel, can you give me rights to the support request section to close items.
Brent do you want me to close all the VQSL up to today or are there any you
want left open for now?

Tim

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Tim McCarron”:

Done.

I think Brent already closed them—I don’t spot any when I search.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Yes, I have closed the VSQL ones and a bunch of others I had already fixed.

B.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)