Release candidate for 3.2.12

We’ve accumulated quite a few bug fixes since 3.2.11:

  • 11084: Additional Selection Highlighters do not work
  • 11083: SumStack() function fails if unit in stack does not define Property
  • 10957: Movement trails trait has incorrect bounding box
  • 10925: IllegalArgumentException due to intransitive Comparator in KeyBuffer.sort()
  • 10897: Windows uninstaller unconditionally removes file associations
  • 10886: Java fails to exit after temporary directory cleanup on Windows
  • 10867: Mac launcher script does not find some Apple JDKs
  • 10686: Using String.isEmpty() is Java-5 incompatible
  • 9483: StackOverflowError while processing InfiniteLoop
  • 2815: NPE in ExtensionsManager.getExtensionsDirectory()

Are there any more bugs for which fixes are forthcoming, or should we release 3.2.12 with these?

i just did the missing documentation for the Mass Piece Loader, I would like to get the Calculated property/Expressions/Beanshell etc. doco done as well. If I have a deadline, I may actually get it done!

Thus spake Brent Easton:

i just did the missing documentation for the Mass Piece Loader,

Saw it. I’ll merge it to trunk momentarily. I’m going through the
tracker right now looking for bugs to close or anything easy to fix.

I would
like to get the Calculated property/Expressions/Beanshell etc. doco done
as well. If I have a deadline, I may actually get it done!

Soon? :slight_smile:

How about by next Sunday?


J.

Sounds like a deadline…I have started.

Though since Expressions are available all over the place, I think I am going to have to a bit of a general update of the Help doco.

I briefly answered a query on Bug 602 (Horizontal scrolling is not supported), but I don’t know what it might take to make the cut. It should would be nice, though.

Thus spake bbbugs:

I briefly answered a query on Bug 602 (Horizontal scrolling is not
supported), but I don’t know what it might take to make the cut. It
should would be nice, though.

I’m trying to determine whether Ctrl is the correct modifier for
horizontal scrolling anywhere. I am starting to suspect that it’s not,
and we should just replace Ctrl with Shift.


J.

How’s this going?

I have made major progress, Have updated all doco for all traits and nearly finished new doco for Calculated Property, Expressions, Expression Builder etc. Trying to get it all done over the next hour or two.

I will need to update doco of non-trait components as well, but I will commit when Traits finished and am happy for that to go out as 3.1.12 and rest to wait if you want to get it out the door.

Ok, I have committed a documentation update for traits. Have revamped and updated all trait doco. Have added a first cut of doco for Calculated properties, Expressions, BeanShell Expressions, Expression Builder.

Anyone, please feel free to review and comment, provide updates, let me know what is missing or needs more info.

Mind providing a link for people who do not use SVN/github/whatnot?

Thus spake grouchysmurf:

Mind providing a link for people who do not use SVN/github/whatnot?

I thought I had.

Here it is:

vassalengine.sourceforge.net/builds/


J.

Thanks; I was thinking of the “doco” itself, but this will do.

Thus spake Brent Easton:

Ok, I have committed a documentation update for traits. Have revamped
and updated all trait doco. Have added a first cut of doco for
Calculated properties, Expressions, BeanShell Expressions, Expression
Builder.

Merged to trunk@9067.

Anyone, please feel free to review and comment, provide updates, let me
know what is missing or needs more info.

Looks like 9889 is still open and is also a documentation bug:

vassalengine.org/tracker/sho … gi?id=9889


J.

3.2.12-svn9069 with some additional bug fixes:

  • 11085: Side selection dialog displayed twice when observer chosen
  • 10260: Added missing documentation for Mass Piece Loader
  • 9888: Added missing documentation for ExpressionBuilder
  • 602: Horizontal wheel scrolling modifier should be Shift, not Ctrl

vassalengine.sourceforge.net/builds/

I’ve backed out the fix for Bug 10295, as we’ve found no way to distinguish Windows machines where it fixes the missing drag ghost problem from Windows machines where it adds a second drag ghost because they never had the missing drag ghost problem to begin with…

So, this gives us the following bug fixes in 3.2.12-svn9077:

  • 11085: Side selection dialog displayed twice when observer chosen
  • 11084: Additional Selection Highlighters do not work
  • 11083: SumStack() function fails if unit in stack does not define Property
  • 10957: Movement trails trait has incorrect bounding box
  • 10925: IllegalArgumentException due to intransitive Comparator in KeyBuffer.sort()
  • 10897: Windows uninstaller unconditionally removes file associations
  • 10886: Java fails to exit after temporary directory cleanup on Windows
  • 10867: Mac launcher script does not find some Apple JDKs
  • 10686: Using String.isEmpty() is Java 5 incompatible
  • 10260: Added missing documentation for Mass Piece Loader
  • 9888: Added missing documentation for ExpressionBuilder
  • 9483: StackOverflowError while processing InfiniteLoop
  • 2518: NPE in ExtensionsManager.getExtensionsDirectory()
  • 602: Horizontal wheel scrolling modifier should be Shift, not Ctrl

Please give 3.2.12-svn9077 a try:

vassalengine.sourceforge.net/builds/

Perhaps we need a preference that turns ‘Software drag ghosting’ on and off, defaulting to off?

Thus spake Brent Easton:

I’ve backed out the fix for Bug 10295,

Perhaps we need a preference that turns ‘Software drag ghosting’ on and
off, defaulting to off?

I looked into that, but so much of AbstractDragHandler is static that it
seemed too painful to change in the time I had last night.


J.

3.2.12-svn9085 has a preference (which appears on Windows only) which lets you force the nonnative drag handler to be used. I can’t test this myself, so I’ll need people using Windows to check whether it works:

vassalengine.sourceforge.net/builds/

3.2.12-svn9090 additionally has fixes for:

  • 11060: Symbol.NatoUnitSymbolSet.createImage() creates images with zero height
  • 9889: Added missing documentation for Module Level Action Button

Thanks to Brent for these.

I installed svn9058 a few days ago, noted the extra drag image, but hadn’t gotten around to testing it when you updated here. Just installed svn9091.

I now have those two and svn9019 (which I had gotten for testing some time ago) and 3.2.11 installed on my machine. The problem is, when I go to install, and chose ‘advanced’ the only version that shows up in the previous install list is 3.1.20 (which is indeed still installed). The 3.2.12 test versions and 3.2.11 don’t show at all, so I can’t tell the installer to remove them. They do show up in the Windows uninstall programs list.