Remaining tasks before 3.1.0-beta1

Hi Joel,

A couple more changed in swampwallaby-merge:

3075: Close handling for ExtensionEditWindow
3076: Track dirty state of ConfigureTree and set new/Edit Extension menu availability correctly.

Last thing on the list is implementing Close Module, which I don’t really want to touch. Unloading a module is tricky. Current implementation just exits the editor completely.

Brent.

Thus spake “Brent Easton”:

Merged at trunk@3077.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Another weirdness: you can open the module editor, then choose Play Module, then choose Edit Module in the module editor. Naturally, this doesn’t work.

rk

Post generated using Mail2Forum (mail2forum.com)

Is there any chance we could change “Play Module” to “Open Module”?
When I first saw that, I had a double-take. There’s a “Close Module” there so I think it should really stay consistent. “Play Module” will be mistaken for Playback to the uninitiated.

Ben

Oh and by the way, can we please take “Load Continuation” out of the File menu?

I keep getting new players saying “I tried to start a log-file and something went wrong”. The first question I always have to ask is “did you use Load Continuation?”. Of course they did!

Thus spake “Rodney Kinney”:

Fixed in uckelman-working@3092.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “bsmith”:

Is the problem the name or the location?


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “bsmith”:

Done in uckelman-working 3095.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

I think it’s both Joel. As far as I’m aware Load Continuation is so rarely used (in my case about twice a year) that it should probably be relegated to somewhere other than the File menu. But a rename would certainly be an acceptable short-term solution.

Thus spake “bsmith”:

“Load Continuation” most likely will disappear when I tackle the logging
RFEs for 3.2. Is it worth changing it just for 3.1? Do you have suggestion
for what to call it instead?


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Actually don’t worry about it for this release thanks Joel, we should probably stick to the feature freeze. I was thinking maybe we could call it “Click to install virus”, maybe that would keep people away :slight_smile:

Funny aside, I think you are on to something here Ben!
Not an immediate need or anything but a ‘donate / contribute’ type of thing
might not be such a bad thing that takes you to the main/donations page on
SF. Perhaps it should be something that goes under the ‘help menu’

Ive just taken a look under Help.
Most pro software usually always has at a minimum

  1. Help
  2. the about info there (version/splashscreen
  3. A connection to the product site for bug reporting/suggestions/downloads
    or similar etc…

Looking at some progs I have:
Outlook, Office, Autocad, CS3, Solidworks, TurboTax, SmartFTP, Skype all do
this as minimum basics in help

Currently we just have (1)Help and (2)the splash screen(about) - but
nothing on version number (part of 2) or (3)a link to resources like vassal
or SF page
Obviously up to y’all if you think we want to mimic this type of standard
software setup, but seems like that’s what your going for

Post generated using Mail2Forum (mail2forum.com)

The version number is on the bottom of the About screen, yes?


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Ah yes. My mistakes - its underneath - blends in to my desktop. Didn’t see
it

Post generated using Mail2Forum (mail2forum.com)

Current build from trunk is svn3103:

nomic.net/~uckelman/tmp/vassal/

This finishes off the custom configurer for the Zoomer, and includes fixes
for various bugs that Michael found in the past week.

We still have these issues, that I know of:

  • Bad positioning of the splitter when loading games.

  • Mac bundle and Windows installer polishing. (I’m going to take care of
    this, since I created them in their present forms.)

  • The Edit menu in the editor is emtpy prior to laoding a module. It would
    be better if the entries were always present, but disabled when no module
    is open.

  • We need to check that the first-time dialog, welcome wizard, &c. still
    work properly in every situation.

Does anyone see these as things we need to take care of before releasing
svn3101 as 3.1.0-beta1? (Or are there other things I’ve missed here?)

The Edit menu is built by the ConfigureTree or ExtensionTree that is created when a module/extension is loaded. You will need to create a dummy menu with disabled entries that do nothing. These will be replace when the module is loaded.

: 269.20.7/1284 - Release Date: 17/02/2008 2:39 PM

There are turn counter issues I will look into, but I don’t know how long that will take. Don’t wait for them.

I though we where going to remove the main VASSAL splash screen, since it only appears for a moment and ends up in the background under windows anyway. How about displaying the VASSAL Splash image at 50% transparency in the PlayerWindow so that it doesn’t look quite so bleak and gives an indication that more will be happening here in later versions?

We have just made a MAJOR GUI change. Are we SURE this is the structure we want, because it would be embarrassing (not to mention extremely annoying for players) if we have to change again. Personally, I think this is definitely th way to go, but are we all happy with it now?

Cheers,
Brent.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

This one is driving me mad.

  • M.

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

It looks good to me so far Joel. The Windows installer is going to get used a ton, so make sure you’re happy with it.

I’m in favour of this, when the window first appears it’s so nice and quick you wonder if you’ve missed something :slight_smile:

All I know is it reduces confusion and streamlines play, I’m hoping that’s not a bad thing!

I know this isn’t high priority for 3.1, but I found a bug in
getLocation(Point). I suspect it’s relatively simple to fix once I
figure out exactly where the problem is.

I shall attempt to fix it ASAP.

  • M.

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

A couple of things.

  • When you open a module you’ve never used before (I tested it with Civil War), it does not ask for a username/password so the username defaults to “newbie”.

  • Also, when opening the “Civil War” module, I’m getting “Unable to create class VASSAL.build.module.documentation.AboutScreen”. Any chance you could just remove this requirement Joel? :smiling_imp:

cheers

Ben