remaining tasks for 3.1.0-beta4

uckelman · October 9, 2008, 11:01am

Due to the large number of fixes since beta3 and the rather long time since
beta3 was released, I’d like to release beta4 soon, remaining open bugs
notwithstanding. My goal is to release beta4 over the weekend, and then fix
all remaining reported bugs for beta5, leading to the release of 3.1.0
on or before Halloween.

Here’s what’s left to do before beta4 is released:

Please work on any outstanding bugs you want fixed before beta4.
I’m doing some tinkering with the BugDialog layout and version lookup for
bug reporting. What I need here is for Rodney to put the report-bug.php and
version-check-bug.php scripts on the server. Also, version-check-bug.php
needs to be updated right after we release beta4 with the svn revision number
corresponding to the beta4 tag.

rk1 · October 9, 2008, 8:13pm

I’ll get the PHP scripts on the site this weekend.

rk

Post generated using Mail2Forum (mail2forum.com)

rk1 · October 10, 2008, 3:32am

They’re live now. Haven’t done any testing – just uploaded the scripts and data files as they exited in SVN.

rk

Post generated using Mail2Forum (mail2forum.com)

uckelman · October 10, 2008, 11:24am

Thus spake “Rodney Kinney”:

Something’s wrong with check-version-bug.php. When I run the current version
from SVN at nomic.net it works, but the one at vassalengine.org gives me this
error:

Parse error: syntax error, unexpected ‘{’ in /home/vassal2/public_html/util/check-version-bug.php on line 42

Is the file at vassalengine.org the same as what’s in SVN?

Also, could you check whether the web server has permission to write the
two log files which these scripts keep?

–
J.

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

uckelman · October 10, 2008, 11:33am

I’ve uploaded svn4202, here:

nomic.net/~uckelman/tmp/vassal/

There are 33 open bugs right now, of which only 12 concern the engine
itself—the rest are problems with individual modules, or VASL—so
we’re in a much better position now than we were when beta3 was
released. (This means we have only 12 known bugs against which to get
duplicate reports, among other things.)

bsmith · October 11, 2008, 10:59pm

So far it looks really good Joel. I like how the module errors are reported in the message window.

I’m not sure if you intended to trap it, but I’m getting a Read/Write Error dialog when I open the Triumph Of Chaos module (version 4e). It’s for a missing image file and should probably also be reported in the message window.

Cheers

Ben

uckelman · October 11, 2008, 11:08pm

Thus spake “bsmith”:

Was this happening for beta3 also?

Report the bug so that I can get an errorLog.

–
J.

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Tim_M · October 11, 2008, 11:15pm

Im still iffy about this - the idea is good but as I noted in this thread
vassalengine.org/forums/viewtopic.php?t=1141

I am still seeing Bad Data: whatever.

Its especially disturbing on GP’s which Ive verified are used and setup correctly (i.e numeric 0-10 with initial value of 0).
My concern is that users are going to see these messages and think something is broke when nothing actually is and flood devs with reports on phantom bugs. The log shows nothing wrong but the error messages persist

[1688490103]
– OS Windows 2003
– Java version 1.6.0_06
– VASSAL version 3.1.0-svn4202
– Manager
C:\Program Files\Java\jre1.6.0_06\bin\java -Xms512M -Xmx1024M -cp lib\Vengine.jar;Vengine.jar VASSAL.launch.Player
[1744462947]
– OS Windows 2003
– Java version 1.6.0_06
– VASSAL version 3.1.0-svn4202
– Player
– Combat Commander version 1.90
Extension CC Battle Pack 1 v1.90 loaded
Extension Nationality Pack 1 v1.90 loaded

uckelman · October 14, 2008, 12:27pm

Thus spake “Tim M”:

Im still iffy about this - the idea is good but as I noted in this thread
vassalengine.org/forums/viewtopic.php?t=1141

I am still seeing Bad Data: whatever.

Its especially disturbing on GP’s which Ive verified are used and setup corre
ctly (i.e numeric 0-10 with initial value of 0).
My concern is that users are going to see these messages and think something
is broke when nothing actually is and flood devs with reports on phantom bugs
. The log shows nothing wrong but the error messages persist

[1688490103]
– OS Windows 2003
– Java version 1.6.0_06
– VASSAL version 3.1.0-svn4202
– Manager
C:\Program Files\Java\jre1.6.0_06\bin\java -Xms512M -Xmx1024M -cp lib\Vengine
.jar;Vengine.jar VASSAL.launch.Player
[1744462947]
– OS Windows 2003
– Java version 1.6.0_06
– VASSAL version 3.1.0-svn4202
– Player
– Combat Commander version 1.90
Extension CC Battle Pack 1 v1.90 loaded
Extension Nationality Pack 1 v1.90 loaded

I wasn’t aware that the Bad Data notices weren’t being written to the log.
They should be.

–
J.

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

bsmith · October 15, 2008, 4:23am

Here’s the error log Joel, there’s no option to report the bug. It’s just a Read/Write Error dialog box.

[1120007882] -- OS Windows Vista -- Java version 1.6.0_03 -- VASSAL version 3.1.0-svn4250 -- Player [1120007882] java.util.concurrent.ExecutionException: java.io.FileNotFoundException: 'images/units.gif' not found in C:\Users\Public\Gaming Stuff\Triumph of Chaos\toc4e.mod at VASSAL.tools.opcache.OpCache.getFuture(OpCache.java:311) at VASSAL.tools.opcache.OpCache.get(OpCache.java:250) at VASSAL.tools.opcache.AbstractOpImpl.get(AbstractOpImpl.java:79) at VASSAL.tools.imageop.AbstractOpImpl.getImage(AbstractOpImpl.java:98) at VASSAL.tools.imageop.SourceOpBitmapImpl.getImage(SourceOpBitmapImpl.java:78) at VASSAL.configure.IconConfigurer.setValue(IconConfigurer.java:62) at VASSAL.tools.LaunchButton.setAttribute(LaunchButton.java:137) at VASSAL.build.module.PieceWindow.setAttribute(PieceWindow.java:279) at VASSAL.build.Widget.build(Widget.java:58) at VASSAL.build.module.PieceWindow.build(PieceWindow.java:135) at VASSAL.build.Builder.create(Builder.java:103) at VASSAL.build.Builder.build(Builder.java:73) at VASSAL.build.AbstractBuildable.build(AbstractBuildable.java:68) at VASSAL.launch.BasicModule.build(BasicModule.java:136) at VASSAL.launch.BasicModule.build(BasicModule.java:101) at VASSAL.build.GameModule.init(GameModule.java:765) at VASSAL.launch.Player.launch(Player.java:112) at VASSAL.launch.Launcher$1.run(Launcher.java:131) at java.awt.event.InvocationEvent.dispatch(Unknown Source) at java.awt.EventQueue.dispatchEvent(Unknown Source) at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source) at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source) at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source) at java.awt.EventDispatchThread.pumpEvents(Unknown Source) at java.awt.EventDispatchThread.pumpEvents(Unknown Source) at java.awt.EventDispatchThread.run(Unknown Source) Caused by: java.io.FileNotFoundException: 'images/units.gif' not found in C:\Users\Public\Gaming Stuff\Triumph of Chaos\toc4e.mod at VASSAL.tools.DataArchive.getImageInputStream(DataArchive.java:227) at VASSAL.tools.imageop.SourceOpBitmapImpl.getImageStream(SourceOpBitmapImpl.java:115) at VASSAL.tools.imageop.SourceOpBitmapImpl.eval(SourceOpBitmapImpl.java:110) at VASSAL.tools.imageop.SourceOpBitmapImpl.eval(SourceOpBitmapImpl.java:43) at VASSAL.tools.opcache.OpCache.getFuture(OpCache.java:307) ... 25 more [1120007882] java.util.concurrent.ExecutionException: java.io.IOException: Unrecognized image format at VASSAL.tools.opcache.OpCache.getFuture(OpCache.java:311) at VASSAL.tools.opcache.OpCache.get(OpCache.java:250) at VASSAL.tools.opcache.AbstractOpImpl.get(AbstractOpImpl.java:79) at VASSAL.tools.imageop.AbstractOpImpl.getImage(AbstractOpImpl.java:98) at VASSAL.tools.imageop.SourceOpBitmapImpl.getImage(SourceOpBitmapImpl.java:78) at VASSAL.configure.IconConfigurer.setValue(IconConfigurer.java:62) at VASSAL.tools.LaunchButton.setAttribute(LaunchButton.java:137) at VASSAL.build.module.Inventory.setAttribute(Inventory.java:667) at VASSAL.build.AbstractBuildable.build(AbstractBuildable.java:56) at VASSAL.build.Builder.create(Builder.java:103) at VASSAL.build.Builder.build(Builder.java:73) at VASSAL.build.AbstractBuildable.build(AbstractBuildable.java:68) at VASSAL.launch.BasicModule.build(BasicModule.java:136) at VASSAL.launch.BasicModule.build(BasicModule.java:101) at VASSAL.build.GameModule.init(GameModule.java:765) at VASSAL.launch.Player.launch(Player.java:112) at VASSAL.launch.Launcher$1.run(Launcher.java:131) at java.awt.event.InvocationEvent.dispatch(Unknown Source) at java.awt.EventQueue.dispatchEvent(Unknown Source) at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source) at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source) at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source) at java.awt.EventDispatchThread.pumpEvents(Unknown Source) at java.awt.EventDispatchThread.pumpEvents(Unknown Source) at java.awt.EventDispatchThread.run(Unknown Source) Caused by: java.io.IOException: Unrecognized image format at VASSAL.tools.ImageUtils.getSmallImage(ImageUtils.java:311) at VASSAL.tools.imageop.SourceOpBitmapImpl.eval(SourceOpBitmapImpl.java:110) at VASSAL.tools.imageop.SourceOpBitmapImpl.eval(SourceOpBitmapImpl.java:43) at VASSAL.tools.opcache.OpCache.getFuture(OpCache.java:307) ... 24 more -- Triumph of Chaos version 0.4e

uckelman · October 15, 2008, 3:47pm

Thus spake “bsmith”:

Build svn4256 has a partial fix for this. Missing images will be reported
to the chat pane along with other data problems, and you’ll get a File
Not Found dialog instead of a generic I/O Error dialog.

–
J.

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

uckelman · October 15, 2008, 7:21pm

Thus spake Joel Uckelman:

As of svn4257, they’re being logged again.

–
J.

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Tim_M · October 15, 2008, 7:35pm

No way to check with windows. Tried to d/l twice. Still got Installer problem - see image

uckelman · October 15, 2008, 7:42pm

Thus spake “Tim M”:

Try now. It works for me when I download it to a Windows machine. I think
you may have finished downloading before I finished uploading.

–
J.

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Tim_M · October 15, 2008, 7:58pm

There we go. That works.

Bad data now being caught

[1506421390]
– OS Windows 2003
– Java version 1.6.0_06
– VASSAL version 3.1.0-svn4257
– Manager
C:\Program Files\Java\jre1.6.0_06\bin\java -Xms512M -Xmx1024M -cp
lib\Vengine.jar;Vengine.jar VASSAL.launch.Player
[2051915359]
– OS Windows 2003
– Java version 1.6.0_06
– VASSAL version 3.1.0-svn4257
– Player
– Combat Commander version 1.90
Extension CC Battle Pack 1 v1.90 loaded
Extension Nationality Pack 1 v1.90 loaded
[2051915359]
Not a number: $Allied Orders$
[2051915359]
java.lang.NumberFormatException: For input string: “$Allied Orders$”
at java.lang.NumberFormatException.forInputString(Unknown Source)
at java.lang.Integer.parseInt(Unknown Source)
at java.lang.Integer.parseInt(Unknown Source)
at
VASSAL.counters.Embellishment.checkPropertyLevel(Embellishment.java:409)
at VASSAL.counters.Embellishment.draw(Embellishment.java:380)
at VASSAL.counters.DynamicProperty.draw(DynamicProperty.java:121)
at VASSAL.counters.ReportState.draw(ReportState.java:87)
at VASSAL.counters.DynamicProperty.draw(DynamicProperty.java:121)
at VASSAL.counters.TriggerAction.draw(TriggerAction.java:78)
at VASSAL.build.module.Map.drawPiecesInRegion(Map.java:1428)
at VASSAL.build.module.Map.paintRegion(Map.java:1392)
at VASSAL.build.module.Map.paintRegion(Map.java:1385)
at VASSAL.build.module.Map$View.paint(Map.java:2485)
at javax.swing.JComponent.paintChildren(Unknown Source)
at javax.swing.JComponent.paint(Unknown Source)
at javax.swing.JViewport.paint(Unknown Source)
at javax.swing.JComponent.paintChildren(Unknown Source)
at javax.swing.JComponent.paint(Unknown Source)
at javax.swing.JComponent.paintChildren(Unknown Source)
at javax.swing.JComponent.paint(Unknown Source)
at javax.swing.JLayeredPane.paint(Unknown Source)
at javax.swing.JComponent.paintChildren(Unknown Source)
at javax.swing.JSplitPane.paintChildren(Unknown Source)
at javax.swing.JComponent.paint(Unknown Source)
at javax.swing.JComponent.paintToOffscreen(Unknown Source)
at
javax.swing.RepaintManager$PaintManager.paintDoubleBuffered(Unknown Source)
at javax.swing.RepaintManager$PaintManager.paint(Unknown Source)
at javax.swing.BufferStrategyPaintManager.paint(Unknown Source)
at javax.swing.RepaintManager.paint(Unknown Source)
at javax.swing.JComponent._paintImmediately(Unknown Source)
at javax.swing.JComponent.paintImmediately(Unknown Source)
at javax.swing.RepaintManager.paintDirtyRegions(Unknown Source)
at javax.swing.RepaintManager.paintDirtyRegions(Unknown Source)
at javax.swing.RepaintManager.seqPaintDirtyRegions(Unknown Source)
at
javax.swing.SystemEventQueueUtilities$ComponentWorkRequest.run(Unknown
Source)
at java.awt.event.InvocationEvent.dispatch(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown
Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown
Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)

Post generated using Mail2Forum (mail2forum.com)

Tim_M · October 15, 2008, 8:38pm

Different Module

Bad Data again but error log appears different so dont know if problem is same or log helps isolate?
This was caused by just opening up the piece palette

[1825595817]
– OS Windows 2003
– Java version 1.6.0_06
– VASSAL version 3.1.0-svn4257
– Manager
C:\Program Files\Java\jre1.6.0_06\bin\java -Xms256M -Xmx512M -cp lib\Vengine.jar;Vengine.jar VASSAL.launch.Player
[2081260645]
– OS Windows 2003
– Java version 1.6.0_06
– VASSAL version 3.1.0-svn4257
– Player
– Successors III GMT version 2.0
[2081260645]
Not a number: null
[2081260645]
java.lang.NumberFormatException: null
at java.lang.Integer.parseInt(Unknown Source)
at java.lang.Integer.parseInt(Unknown Source)
at VASSAL.counters.Embellishment.checkPropertyLevel(Embellishment.java:409)
at VASSAL.counters.Embellishment.draw(Embellishment.java:380)
at VASSAL.counters.Embellishment.draw(Embellishment.java:378)
at VASSAL.counters.DynamicProperty.draw(DynamicProperty.java:121)
at VASSAL.counters.RestrictCommands.draw(RestrictCommands.java:74)
at VASSAL.counters.RestrictCommands.draw(RestrictCommands.java:74)
at VASSAL.counters.SubMenu.draw(SubMenu.java:115)
at VASSAL.counters.DynamicProperty.draw(DynamicProperty.java:121)
at VASSAL.counters.TriggerAction.draw(TriggerAction.java:78)
at VASSAL.counters.TriggerAction.draw(TriggerAction.java:78)
at VASSAL.counters.TriggerAction.draw(TriggerAction.java:78)
at VASSAL.counters.TriggerAction.draw(TriggerAction.java:78)
at VASSAL.counters.UsePrototype.draw(UsePrototype.java:171)
at VASSAL.counters.Embellishment.draw(Embellishment.java:378)
at VASSAL.counters.UsePrototype.draw(UsePrototype.java:171)
at VASSAL.counters.Embellishment.draw(Embellishment.java:378)
at VASSAL.counters.UsePrototype.draw(UsePrototype.java:171)
at VASSAL.counters.DynamicProperty.draw(DynamicProperty.java:121)
at VASSAL.counters.DynamicProperty.draw(DynamicProperty.java:121)
at VASSAL.counters.Delete.draw(Delete.java:127)
at VASSAL.counters.RestrictCommands.draw(RestrictCommands.java:74)
at VASSAL.counters.RestrictCommands.draw(RestrictCommands.java:74)
at VASSAL.build.widget.PieceSlot.paint(PieceSlot.java:156)
at VASSAL.build.widget.PieceSlot$Panel.paint(PieceSlot.java:94)
at javax.swing.JComponent.paintChildren(Unknown Source)
at javax.swing.JComponent.paint(Unknown Source)
at javax.swing.JComponent.paintChildren(Unknown Source)
at javax.swing.JSplitPane.paintChildren(Unknown Source)
at javax.swing.JComponent.paint(Unknown Source)
at javax.swing.JComponent.paintChildren(Unknown Source)
at javax.swing.JComponent.paint(Unknown Source)
at javax.swing.JComponent.paintChildren(Unknown Source)
at javax.swing.JComponent.paint(Unknown Source)
at javax.swing.JComponent.paintChildren(Unknown Source)
at javax.swing.JSplitPane.paintChildren(Unknown Source)
at javax.swing.JComponent.paint(Unknown Source)
at javax.swing.JComponent.paintToOffscreen(Unknown Source)
at javax.swing.RepaintManager$PaintManager.paintDoubleBuffered(Unknown Source)
at javax.swing.RepaintManager$PaintManager.paint(Unknown Source)
at javax.swing.BufferStrategyPaintManager.paint(Unknown Source)
at javax.swing.RepaintManager.paint(Unknown Source)
at javax.swing.JComponent._paintImmediately(Unknown Source)
at javax.swing.JComponent.paintImmediately(Unknown Source)
at javax.swing.RepaintManager.paintDirtyRegions(Unknown Source)
at javax.swing.RepaintManager.paintDirtyRegions(Unknown Source)
at javax.swing.RepaintManager.seqPaintDirtyRegions(Unknown Source)
at javax.swing.SystemEventQueueUtilities$ComponentWorkRequest.run(Unknown Source)
at java.awt.event.InvocationEvent.dispatch(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)

Tim_M · October 15, 2008, 8:44pm

Got another Bad Data in another module but this one let me send a bug report
in - works good

Post generated using Mail2Forum (mail2forum.com)

rk1 · October 17, 2008, 3:46am

It’s because the site is running PHP 4.4.9, and try/catch was introduced in PHP 5.

Can you change the script to run under PHP 4? I can ask the hosting service to upgrade, but there’d need to be a lot of regression testing of the site.

rk

Post generated using Mail2Forum (mail2forum.com)

Brent_Easton · October 17, 2008, 6:30am

Anyone else having trouble running the latest trunk? It keeps bailing on me unable to find org/apache/xerces/impl/xs/psvi/PSVIProvider, but I can see it in XercesImpl.jar which is in the Classpath.

Joel, you mentioned something about the XML libraries, are the set we have now compatible?

B.

uckelman · October 17, 2008, 8:46am

Thus spake “Rodney Kinney”:

No, don’t do that. I’ll see what I can do to modify it.

Since this wasn’t working and I hadn’t heard back by the time I wanted to
release beta4, I left it checking the scripts at nomic.net, which is fine
for now.

–
J.

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)