remaining tasks for 3.1.0

Thus spake “Brent Easton”:

You could use URLDecoder.decode().

Why is the ‘#’ getting urlencoded in the first place? Wouldn’t it be better
to stop that?


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Found the problem. There is a HelpFile.getReferenceManualPage() has a different method to use when opening a help file with an anchor.

Fixed in swampwallaby-work2@5025

B.

*********** REPLY SEPARATOR ***********

On 1/02/2009 at 10:02 PM Joel Uckelman wrote:


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

Merged to 3.1@5026, trunk@5027.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

swampwallaby-work2@5028 contains a fix for

Bug [2556069] NPE if SendToLocation fails

There where two problems:

If the SendToLocation fails (e.g. sending to a non-existent zone), it is just supposed to report a Bad Module Data to the Chat window. However

  1. It was generating a Bug Report dialog in addition to tghe Bad data report

  2. The details of the Bad Module Data are not being reported in the Chat Window.

B.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Brent, I believe #2 is true in most cases.

Everytime I’ve seen a “Bad Module Data” there is nothing in the chat except
that
Very common with DP’s dependent with GP’s not set right

Post generated using Mail2Forum (mail2forum.com)

Case in point:
Heres an example someone pointed out to me but didn’t know what is wrong - I did from looking at the log (a missing image), but as you can see, nothing in the chat window tells the user that

see image

Yes, I know. It used to be there, but the info display got dropped off in one of the beta’s. The full error message is in the errorlog.

Here is what a typical Bad Data error is supposed to look like:

  • Bad Data in Module: Devastated [Send to Location - Send] - Zone not found Zone=Missing

B.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Very cool.

Perhaps this reporting can be reimplemented across board in 3.2?
I realize its not useful to dev in most cases but will be for design and
perhaps w/ bugzilla easier to categorize for designers to see problems with
their mods - less headaches for devs

Post generated using Mail2Forum (mail2forum.com)

Tim,

??? This is the 3.1 reporting that will be in the next daily build of beta8.

Yes, that’s right. That’s the way I designed it, but a bug crept in that made it dissappear.

B.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Gotcha - dont have next daily build, my bad, which btw reminds me, what is
the setup now for Libraries in eclipse…
Think Mike hinted at this earlier. Haven’t been able to run direct out of
there in ages

Post generated using Mail2Forum (mail2forum.com)

For now…

In the Build Path - Order and Export tab, move the XercesImpl.jar above the Xalan.jar.

We will have new versions of the library jars soon that will remove the need for this.

B.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

Merged to trunk@5033, 3.1@5034.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)