remaining tasks for beta3

I’d like to start (again) a list here of tasks which we want to keep
tabs on.

I’m going to be back in Amsterdam for the first time in two months on
Wednesday, and am part of a workshop from Wednesday to Friday. A week
from tomorrow, I leave for the States for 10 days at some ungodly hour
or the morning and will spend a good part of that time in the middle of
nowhere without reliable internet access, so I’d like to put out another
beta on or before 9 June.

Some things which I’d still like to fix myself:

  • Incorporate the bug reporter.

  • Incorporate the new message dialog and fix up error messages. There’s
    quite a bit to this, actually. Right now, we have a bunch of problems in
    this area, roughly:

  1. Uncaught exceptions which we purposely (!) throw. Any exception which
    is kicked all the way up to the top is either caused by a bug or some
    kind of system failure. We shouldn’t throw RuntimeExceptions ourselves
    for things which aren’t programming errors.

  2. Overbroad catches. There are a bunch of places where we catch Exception,
    when we should be handling the exceptions we know how to handle and letting
    the others percolate upward.

  3. Exceptions which are swallowed. There are numerous places where we just
    eat an exception, when we should at least report it to the error log. (It
    was this one which led me to redo the message dialogs.)

I don’t expect to fix this completely by next week, but I do expect to fix
the more egregious parts of it.

  • Grow box weirdness on Macs. (no clue how to fix this…)

  • Controls window does not come to front on Macs.

  • Uncaching ImageOps.

  • Do something sane and nonviolent (if possible) with file choosers to
    get file filtering.

  • Fix font loading for SVG.

  • Notify the MM when a module or game is saved.

Some things which I’ve tried to fix without success and wish somebody
else would try:

  • The Server Status pane is always hidden on startup, regardless of
    the user’s preferences (which I’ve verified are read correctly).

Other things I know about but have not worked on and am not claiming at
the moment:

This is (most) of what I found from drilling back to the end of February
through the mail I’ve kept in my “vtodo” folder.

An aside: I’m finding that both the forum and an email folder are crap for
tracking tasks. I’m not keen on the trackers at SF either—too slow, and
I don’t like the interface. (For comparison, Bugzilla has a tremendously
better, cleaner interface.) If I were to set up a Bugzilla instance at
nomic.net (or, alternatively, if we had one at vassalengine.org) would
anyone else but me make serious use of it?

Thus spake “Michael Kiefte”:

If I’d set it up a week ago, I think the setup time would already be
paid off, since I’ve spent at least that long since then just sorting
mail to find messages related to bugs.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Michael Kiefte”:

What about Trac? Any opinons about that?


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Joel,

Some of these do not indicate reportable errors. I have tried to document this fact where this occurs.

Ok, Ok, I’ll have a look at this one. I have had experience with fixing preference weirdness before :slight_smile:

These problems should be fixed in beta 3 already - This is the Masked properties issue.

Yes. Whatever you decide on, I am happy to use. I have little experience with either bugzilla or Trac, but anything would have to be better than SF.

Brent.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

Oh, I know. I’m not saying they’re all that way, just that I’ve found
some which are.

It has nothing to do with the prefs. I’ve verified that the values being
retrieved from the prefs are always correct. The problem is with the
ComponentSplitter.

Ok, I’m going to do it, then. Probably not before mid-June, though.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Yes, homing in on it now.

With existing SF issues transferred over?

B.

Thus spake “Brent Easton”:

Yeah, I would transfer those. I’d also add about a hundred new ones.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Oups …

The new French Vassal Game Designer has done a Timer Class to count the remaing time when you must play in a limited time …

I join here a capture in editor mode too …

The source of the Timer :

membres.lycos.fr/nirrey/VassalFo … ule/alpha/

The FMP module uses it …

And the Java directory with class and source …

The only thing is that he can not display on the Vassal Toolbar the timer icon …

Now it’s up to you to do what you want … but you know that

Joel,

swampwallaby-work@3717 should cope with this. It works on Windows, can you check it on Linux please? I have not implemented it on the PlayerWindow yet, there are a few issues with that.

If you maximize the Module Manager Window, then quit, then restart, the Module Manager should open in the pre-maximised size. I believe this is the sensible thing to do, but am open to arguments.

I will be away all weekend plus Monday, so have little time left to fix more bugs. The main one I have is the stacking issue found by Hagar. I would have bet big money that this was actually a problem with the module, but I would have lost! There is a bug which causes units to not find any candidates to merge with in the target hex, even when there is one there. It depends on exactly where the counters is when it is released. I am homing in and plan to get it fixed today.

B.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

One other issue:

  • Keyboard shortcuts for menus have disappeared

This is a must-fix for me. I always hit ALT+F L to load a new game, etc. and it kills me every time I run the beta.

rk

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Rodney Kinney”:

Do you know how to specify these from within the i18n strings? Because
that’s really how it should be done—“L” won’t make sense (or maybe
even be present) in all “Load Module” strings in all languages.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

The OrderedMenu class used the first character in the i18n string. Kind of a hack but better than nothing. The better alternative would be to actually create a one-character translatable string that represents the keyboard shortcut.

rk

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Rodney Kinney”:

That’s almost certain to get out of sync with the item text. In some
toolkits (Qt, for example) the mnemonic letter can be marked in the item
text with an ‘&’. I’ll modify MenuProxy and MenuItemProxy to work that
way.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Hello, what about this:
vassalengine.org/forums/viewtopi … =5520#5520

Would it be very difficult to implement this ?

Thus spake “mehrunes”:

It appears to already be implemented.

I’m expecting to release beta3 on Monday, before I leave for 10 days.
Brent’s away now, and he’s the most likely one to review this code.
This will have to wait for beta4.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thks.

Yes, I am still trying to work out how to turn that off. It annoys me also.

B.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

I don’t expect to release beta3 in the 45 minutes before I leave for the
airport, so it’s going to have to wait until the weekend. (I’m merge the
unmerged then, as well.) Hopefully this means that while on the plane
today I’ll be able to wrap up my work on the new error dialogs.

Hi Joel,

swampwallaby-work@3737 fixes a bug I just found in Send To Location when offsets are used.

Outstanding unmerged in swampwallaby-work are:

3710 Fix Server Status Controls Bug
Save Module Manager size, position and divider location in prefs
3712 Fix PositionOption to ensure restored windows are completely on the current Desktop
3717 Add support for window maximising to PositionOption
3719 Fix snapTo bug when Hex vertices are valid snap locations
3737 Fix bug in Send To Location

Brent.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

This works on Linux when using Metacity as the window manager.

I still think that we should be letting the window manager set the window
location rather than setting it ourselves—otherwise, VASSAL won’t appear
in the expected place (which in some cases is where it was the last time
it was run, and in others not) on the screen in many window managers.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

These three are merged to the trunk. I’ve run out time for tonight to
merge the remaining two. (My in-laws want to go to sleep now.)


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)