remaining tasks for beta8

Gentlemen, we’re nearly there.

Here’s what I believe is still left for beta8:

  • Spanish translation.
  • Japanese translation.
  • A few minor icon-related things. (Joel)
  • 2286742: IllegalArgumentException in WizardSupport.showWelcomeWizard (Rodney)
  • 2265820: StackOverflowError in LaunchButton$1.actionPerformed() (Joel)

Somewhat irritatingly, we’ve had no further reports of two bugs which we
wanted to see more of in order to understand them:

  • 2432256: ArrayIndexOutOfBoundsException in Embellishment
  • 2372121: No exception in errorLog

Since we’re not getting any reports of these, they’re likely not affecting
too many people at present, and we can always fix them later if we figure
out their causes.

On Wed, Jan 14, 2009 at 03:09:42PM -0800, uckelman wrote:

How much of the translation is missing? I could fill in small stuff,
but don’t have the time to do tons. (Fluent Costa Rican Spanish
speaker/writer)

Jeff


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake Jeffrey Brent McBeth:

I don’t really know, to be honest. I think Rodney already has someone
on it, though—we’re just waiting for whomever that is.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “uckelman”:

Fixed in trunk@4863.

I made a few small modifications, namely that:

  1. the recursion depth is incremented inside a try block and decremented
    in a finally block, to ensure that no matter what exceptions are thrown,
    it always is properly decremented.

  2. The InfiniteLoopException is now a private static class. If it’s not
    static, then there are odd problems with it being serialized out to the
    Logger.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

I’ve gotten responses from the people who did the last Spanish and Japanese translations. They’ve both indicated they’re happy to do it, so I’m just waiting for their submissions.

rk

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Rodney Kinney”:

Would you remind them to work from whatever the current development build
is? We keep adding small numbers of keys over time, and it would be best
if they were working from a current set.

Actually, we’ve added a handful since we got the Italian, German, and Dutch
translations, too. I don’t forsee there being any new keys for 3.1 from here
on—I just took care of the last bug which involved adding keys, so maybe
you could get those translators to take one last look? (Would it help if
I specified what the new keys are? I could do that pretty easily…)


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

One more thing: I’m waiting for confirmation of whether there’s still a problem with icon transparency on the Mac. If there is, then I want to start asking about this on the Java Mac list so we can get a solution.

Joel,

There is a preblem with the repacking of the Bug Dialog window when you click on the Show Details widget (Bug 2521503).

B.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

Hmm. Must happen only on Windows.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Can anyone with a Mac please look into this for me? I can’t do it myself.

On Jan 20, 2009, at 6:54 AM, Jeffrey Brent McBeth wrote:

I took a look at this.

Apparently the issue seems to be that the dock likes to use large
icons (256x256 or 512x512), and the scaling up of smaller icons to
that size doesn’t seem to preserve the transparency.

I sent a message with a screenshot to this thread, but it got held up
in moderation because of the attachment size. :frowning:


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Following up on this.

Here is the view of the *.icns file from the Mac application, as seen in Apple’s Icon Composer application. It shows that the larger icons are the ones that aren’t present in the file. I also show the views of the file where the additional, missing large sizes are created.

That suggests that what is needed is a 512x512 icon (and optionally, I guess 256x256) to support the Mac doc.

Thus spake Thomas Russ:

The ICNS file I created contains icons at 256x256 and 512x512. Aren’t
they being used? Why does the icon for the MM show up properly? The
icons for the MM and the Player come from the same ICNS file.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “tar”:

I’m perplexed. I built the ICNS file with those sizes.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

On Jan 20, 2009, at 9:47 AM, Joel Uckelman wrote:

Actually, since the file as shown in preview does show those icons, it
actually makes sense that they would be in the file. I don’t think
the Preview application would create scaled versions.

I’m not sure what to suggest. Perhaps you should send me the raw icon
files, and I will create a *.icns file using Apple’s Icon Composer.
Then you would have something to compare against what is being
generated.

It is also weird that the icon would work correctly for Vassal’s MM
but not the player or editor. There’s some serious weirdness going on
here.

-Tom.
tar@isi.edu


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake Thomas Russ:

The icons I used to create the ICNS file with png2icns are here:

nomic.net/~uckelman/tmp/vassal/icon/

Thanks for looking into this for me.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Well, the results from using Apple’s tool end up a bit different, but I didn’t try to analyze the file. I’m not really sure what would be a good way to do that.

I am attaching the Apple tool version here.

One thing I did notice, is that when I went looking at the Google-found documentation for “png2icns” is that I found the following at icns.sourceforge.net/

That seems to suggest that some versions of the libicns will not work properly with the larger size icons. In particular it seems that it needs to be properly linked against Jasper for that to work. Does that sound like something that could be the root of the problem?

Thus spake “tar”:

Thanks.

The build of libicns in Fedora 10 claims to be linked against Jasper.

Here’s something interesting I get when I try to list the contents of
the icon file you posted:

[uckelman@scylla 3.1]$ icns2png vassal-apple.icns -l

Reading icns family from vassal-apple.icns…
Icon family type is ‘icns’
Icon family size is 180945 bytes
Listing icon elements…
‘is32’ 16x16 32-bit icon (1024 bytes compressed to 719)
‘s8mk’ 16x16 8-bit mask (256 bytes)
‘il32’ 32x32 32-bit icon (4096 bytes compressed to 2236)
‘l8mk’ 32x32 8-bit mask (1024 bytes)
‘it32’ 128x128 32-bit icon (65536 bytes compressed to 18266)
‘t8mk’ 128x128 8-bit mask (16384 bytes)
‘ic08’ 256x256 32-bit icon (262144 bytes compressed to 41997)
‘ic09’ 512x512 32-bit icon (1048576 bytes compressed to 99979)
libicns: icns_get_image_info_for_type: Unable to parse icon type ‘icnV’
‘icnV’ 0x0 0-bit (4 bytes)
9 elements total in vassal-apple.icns.

And when I try to extract them:

[uckelman@scylla 3.1]$ icns2png vassal-apple.icns -x

Reading icns family from vassal-apple.icns…
Saved ‘is32’ element to vassal-apple_16x16x32.png.
Saved ‘il32’ element to vassal-apple_32x32x32.png.
Saved ‘it32’ element to vassal-apple_128x128x32.png.
icns2png: jpc_dec.c:1072: jpc_dec_tiledecode: Assertion `dec->numcomps == 3’ failed.
Aborted

The assertion is failing during the extraction of the 512x512 icon. The
other three are written to disk successfully.

When I try to extract icons from the ICNS file that I built myself, they
all extract successfully (and the weird 0x0 icon is not listed at all).

Is this a bug in libicns? Is this a bug in Icon Composer?


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

I can’t get this to happen on Windows XP with svn4958. Does it still happen
for you on Vista with that build?


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

On Jan 22, 2009, at 6:23 AM, Joel Uckelman wrote:

I do wonder if this is a version number?

I’m not sure about libicns.

If it is a bug in Icon Composer, it is one that seems to not affect
the use under Mac OS X, so it is more likely to be something that is
intentional. Or at least the Mac OS is bug compatible with it.

I did find a thread about difficulties using OpenJPEG with *.icns, but
I don’t really understand what is going on there:

groups.google.com/group/openjpeg … 5da55c3206


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)