test build for 3.1.1

Development
1

I’ve uploaded 3.1.1-svn5326, which collects the 15 bug fixes we’ve made since releasing 3.1.0:

  • Bug 2688226: NPE Adding Preference
  • Bug 2687265: NPE in SendToLocation
  • Bug 2687178: Mark unmoved button appears even if icon set to null
  • Bug 2686890: Turn Counter does not respond to Hotkeys when undocked
  • Bug 2686888: Turn Counter always increments/decrements by 1
  • Bug 2685559: NPE in Embellishment.getMatchingActivationChar()
  • Bug 2684931: ClassCastException when loading module
  • Bug 2672959: Old Java fails to read PNGs with small palettes
  • Bug 2676355: Bug Dialog sometimes hangs over other modal dialogs
  • Bug 2673589: ImageIO throws IllegalArgumentException reading bad mages
  • Bug 2665747: NPE in MovementReporter reporting Drag & Drop move
  • Bug 2658210: OutOfMemoryError in Importer should not generate Bug Dialog
  • Bug 2653477: ArrayIndexOutOfBoundsException in Embellishment.getLocalized
  • Bug 2630529: NPE in ModuleManager displaying newly added module info
  • Bug 2432256: ArrayIndexOutOfBoundsException in Embellishment

Please give this build a try. If this works for everyone at least as well
as 3.1.0, then I’ll release it as 3.1.1 this evening or on Tuesday.

2

Looks good to me.

Let’s get it out the door - the minor bugs fixes look like they will keep flowing steadily, so let’s aim for 3.1.2 in another 2 weeks.

swampwallaby-3.1@5329 has fix for:

Bug [2689040] StringIndexOutOfBoundsException inviting peer2peer players

B.

*********** REPLY SEPARATOR ***********

On 16/03/2009 at 3:15 AM uckelman wrote:

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

3

Thus spake “Brent Easton”:

What exactly is going on in this one? I tried to understand it but I don’t
yet see why removing all of the whitespace is the solution to the problem.

–
J.

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

4

The user is asked to enter a freeform address in the form 202.133.4.208:5050 and this is passed into PeerInfo.deFormat() to split it up.

However, PeerInfo.deformat() (and .format()) is a dual-purpose routine and is used elsewhere to deformat a more complete data structure which actually looks like

202.133.4.208:5050 chat_name

The parsing is pretty rude and just looks for ‘:’ and ’ ’ and splits it up with substring. If you include an extra space, before the colon, or before the IP number, the whole thing fails.

Users do not know anything about Chat names, they are not supposed to enter them here, so any whitespace they enter at this point is superfluous, and only confuses the deFormat() routine.

B.

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

5

Thus spake “Brent Easton”:

Thanks for the explanation.

Merged to 3.1@5340, trunk@5341.

–
J.

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)