# Updating saved scenarios **URL:** \ **Category:** Module Design\ **Created:** [January 22, 2008, 7:26pm UTC](https://forum.vassalengine.org/t/updating-saved-scenarios/164 "2008-01-22T19:26:46Z")\ **Posts on this page:** 4\ **Page:** 3
**Author:** ![Brent\_Easton](https://forum.vassalengine.org/user_avatar/forum.vassalengine.org/brent_easton/32/10_2.png) [@Brent\_Easton](https://forum.vassalengine.org/u/Brent_Easton)\ **Post date:** [February 1, 2008, 3:44am UTC](https://forum.vassalengine.org/t/updating-saved-scenarios/164/41 "2008-02-01T03:44:56Z")
> [@](#): > > Not a great name, but > > getMapCollection() That works for me. Joel - swampwallaby-latest@2943 includes this refactor, plus a small change to the visiblity of PlaceMarker.createMarker() I need for the new game updater. Feel free to rename it Brent. ---
**Author:** ![uckelman](https://forum.vassalengine.org/user_avatar/forum.vassalengine.org/uckelman/32/10020_2.png) [@uckelman](https://forum.vassalengine.org/u/uckelman)\ **Post date:** [February 1, 2008, 9:12am UTC](https://forum.vassalengine.org/t/updating-saved-scenarios/164/42 "2008-02-01T09:12:39Z")
Thus spake Thomas Russ: > [@](#): > > On Jan 31, 2008, at 3:01 PM, Joel Uckelman wrote: > > > [@](#): > > > > > [@](#): > > > > > > 2927: Refactor Map.getAllMaps() to return Collection instead > > > of Iterator > > > (FIXME) > > > > Is changing the return type a good way to fix this? Doing so ensures > > that any custom code which called Map.getAllMaps() is broken now. > > The FIXME (which I put there) was intended to remind me to create a > > different function which returns a Collection (or a List?) and then > > deprecate getAllMaps()—probably I should have been more explicit > > about > > that in the FIXME. I would have done it at the time instead of putting > > a FIXME in, but I couldn’t think of a good name for the new function. > > Not a great name, but > > getMapCollection() I was thinking getMapList(), if that’s not taken. (And return a List, so that we return as specificly as we can.) – J. * * * Messages mailing list [Messages@forums.vassalengine.org](mailto:Messages@forums.vassalengine.org) [forums.vassalengine.org/mailman/ … engine.org](http://forums.vassalengine.org/mailman/listinfo/messages_forums.vassalengine.org) Post generated using Mail2Forum ([mail2forum.com](http://www.mail2forum.com)) ---
**Author:** ![uckelman](https://forum.vassalengine.org/user_avatar/forum.vassalengine.org/uckelman/32/10020_2.png) [@uckelman](https://forum.vassalengine.org/u/uckelman)\ **Post date:** [February 1, 2008, 1:06pm UTC](https://forum.vassalengine.org/t/updating-saved-scenarios/164/43 "2008-02-01T13:06:30Z")
Thus spake “Brent Easton”: > [@](#): > > > [@](#): > > > > Do you think GPIDSupport would be a better name for TopLevelComponent? > > Sure, feel free to change things like that. I guess I was thinking Form rathe > r than Function. Potentially, there may one day be other not-gpid stuff that > will be shared between GameModule and ModuleExension. If they both has the sa > me parent class, I would have added a new parent instead. Done. I called it GpIdSupport, following your capitalziation. – J. * * * Messages mailing list [Messages@forums.vassalengine.org](mailto:Messages@forums.vassalengine.org) [forums.vassalengine.org/mailman/ … engine.org](http://forums.vassalengine.org/mailman/listinfo/messages_forums.vassalengine.org) Post generated using Mail2Forum ([mail2forum.com](http://www.mail2forum.com)) ---
**Author:** ![uckelman](https://forum.vassalengine.org/user_avatar/forum.vassalengine.org/uckelman/32/10020_2.png) [@uckelman](https://forum.vassalengine.org/u/uckelman)\ **Post date:** [February 1, 2008, 1:07pm UTC](https://forum.vassalengine.org/t/updating-saved-scenarios/164/44 "2008-02-01T13:07:14Z")
Thus spake “Brent Easton”: > [@](#): > > > [@](#): > > > > Not a great name, but > > > > getMapCollection() > > That works for me. > > Joel - swampwallaby-latest@2943 includes this refactor, plus a small change t > o the visiblity of PlaceMarker.createMarker() I need for the new game updater > . > > Feel free to rename it > > Brent. Done. I called it getMapList(), and it returns a List, which is fine since that’s a subinterface of Collection. – J. * * * Messages mailing list [Messages@forums.vassalengine.org](mailto:Messages@forums.vassalengine.org) [forums.vassalengine.org/mailman/ … engine.org](http://forums.vassalengine.org/mailman/listinfo/messages_forums.vassalengine.org) Post generated using Mail2Forum ([mail2forum.com](http://www.mail2forum.com)) [Previous page](https://forum.vassalengine.org/t/updating-saved-scenarios/164.md?page=2)