VASSAL 3.1.0-beta1 is released

Thus spake “Rindis”:

BTW, it does them no good to complain where we won’t hear them. If they’d
told us, we might have tackled it sooner.

Sure, please do.

J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Yeah, well dragging them into the larger community is hard. (Consider that most of them play just F&E and maybe SFB.) And with the existing Cyberboard version, pickup has been slow. It’s relatively recently that I’ve gotten the feature set up to the point where the ‘old-timers’ are starting to notice (the user support I have is mostly newer arrivals). I should have pushed on it more. But then, when I got to where it really was my top priority, another user tried one of the test builds and reported on the performance gain. So I waited for a beta to test. :smiley:

Comments from the forum so far:
Ken Watanabe (Watank) on Tuesday, May 13, 2008 - 06:51 pm:

Holy cow… it’s like night and day on my 2.4 GHz ModBook running 10.5 - GW start file loaded in <10 secs (Vassal itself loaded in a flash)… The Mac version is an application bundle on a disk image, so a simple drag-n -drop install.

Definitely going to play with it on the commute home :smiley:

Jason E. Schaff (Jschaff297061) on Tuesday, May 13, 2008 - 07:12 pm:

Mother of pearl!

Someone on the Vassal team deserves major kudos. Not quite as fast here as you guys are reporting, but still only took about 1:45 to go from cold start to finishing the load of the GW scenario. (PowerMac G5, dual 2 GHZ, OS 10.4). Firewall settings may have slowed things down a little.

Thus spake “Michael Kiefte”:

I don’t expect restaurants to work like software, but if it’s a restaurant
that I like otherwise, I will tell them if the food was bad.

I don’t ever intend to.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

HiHo,
is there any thing I can do concerning my ADC2 conversion problem ?

I used Vista (as you see in the log), I also tested it in Wind XP SP2 VMWare environment and got the same message.

Best Regards
Chris

Thus spake “Biswut”:

I don’t believe anyone has had a chance to look at it yet. Two of
us four developers are travelling at the moment and we’re receiving
a lot of bug reports right now. We will look at yours, but it might
be several days before that happens.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Dear J ,

th@nx for the status.
It’s not really urgent :slight_smile:

Chris

Thus spake Joel Uckelman:

This is fixed in trunk@3642. As a side-effect, the launch process for
Players and Editors is somewhat less tangly than before, since I needed
to do some refactoring in order to fix the bug.

The error dialog needs to be replaced with something more presentable,
but you won’t get any exceptions now if you try to load a non-module.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

I was looking at your F&E module just now—what are you doing with those
inventories so that they take so long to load? Either you’re doing something
wrong, or Inventory needs some serious optimization attention.

Thus spake “Biswut”:

Michael, have you had a chance to look at this yet? It appears that the
ADC2 importer is writing out a raw ampersand instead of writing it as
‘&’.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Michael Kiefte”:

Yeah. ‘<’ and ‘>’ are also evil and need to be replaced with their
entities, and double and single quotes should be replaced within
when they need to appear within an already double- or single-quoted
attribute.

I don’t know—what’s actually doing the writing?


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Michael Kiefte”:

They’re not supposed to go in CDATA. Hmmm. Possibly then that “&#1
is really an entity which isn’t recognized.

I think you need to get the ADC2 module in order to move on from here.

J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

HiHo,

I hope I can help here.
The module is no longer sold, it’s free, because ADC2 will not be maintained in the future.

You can donwload it here:

67.155.107.229/COA/Struggle%20fo … pe-Med.exe

Best regards
Chris

(I hope the link works, otherwise I can mail it, its just 1,5 Megs)

Thus spake “Michael Kiefte”:

I think I have something unprintable to say about putting unprintable
characters into strings.

Argh. That’s really nasty. Doing this kind of checking is going to be
slow, so putting it into ArchiveWriter would make all saving slow,
when it’s only needed for doing imports.

What’s actually the right thing to do here? Are these characters junk?
How’d the y get there?

I think you could just do something like this, if it’s ok to chuck
those characters, and if you won’t see any Unicode characters:

final Pattern p = Pattern.compile(“[^\x32-\x7E]”);
String fixed = p.matcher(bad).replaceAll(“”);

(You want to hang on to the Pattern, and reuse it to create your Matchers.)


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake Joel Uckelman:

A better pattern would be “[^\x32-\x7E]+” since you may as well remove
as many of them in one go as you can.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

HiHo,

sorry for coming up with this problem.

I just like the Game . . .

If I can do anything, please let me know.

Best regards
Chris

Thus spake “Michael Kiefte”:

Man, that’s really grotty. It’s not like this was a good idea in 1997 or
whenever, either.

Well, you could (should) encapsulate the fixer-upper in a function.

Also, it’s probably worth trying this, too, as it might be a lot faster
than using a regex:

String fixup(String s) {
final int len = s.length();
final StringBuilder sb = new StringBuilder(len);

char ch;
for (int i = 0; i < len; i++) {
ch = s.charAt(i);
if (ch >= 0x20 && ch <= 0x7E) sb.append(ch);
}

return sb.toString();
}

Will it be that hard? Aren’t you looking for instances of ‘new String’
and toString() and such?


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Biswut”:

No need to be sorry. You’re doing us a favor by reporting bugs.
We can’t fix bug we don’t know about.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Michael Kiefte”:

Michael, do you also want to chuck chars greater than 0x7E? (0x7F is
DEL, for example.)


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Michael Kiefte”:

Ok. In the long-term, we should probably plan to sanitize all input from
importers, but this is probably ok for now. (Does it matter that the other
strings you’re reading in aren’t null-terminated? How are they
terminated? Do you have byte-lengths appearing before them?

I have several more as well—but I’m at a point where all of them
depend on input from other people first, so I’m going to go have a
beer soon.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Dear Joel,

as I have quite a few ADC2 modules, would it help to test more or better wait for beat 2 ?

Have fun with the beer. (Prost !)

Chris