VASSAL 3.1.0-beta4 released

Joel,

swampwallaby@4357 has the fix for

Bug [2172904] NPE in StackMetrics.merge()

Michael, this is one of yours, but I was checking a duplicate and had a quick look and realised what the problem was. It’s part of some new code that went in, but it did not take into account that it is possible to have single counters on a board that do not belong to a Stack and do not have a parent.

B.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thanks Brent,

I couldn’t reproduce it at all, but that’s okay, because in the process of trying to reproduce the bug, I found a completely unrelated one.

Did you make the fix? Can I change the status of the bug?

  • M.

2008/10/28 Brent Easton <b.easton@exemail.com.au (b.easton@exemail.com.au)>


Michael Kiefte, Ph.D.
Associate Professor
School of Human Communication Disorders
Dalhousie University
Halifax, Nova Scotia, Canada
tel: +1 902 494 5150
fax: +1 902 494 5151

Post generated using Mail2Forum (mail2forum.com)

I have fixed it in my branch. I usually leave the bug Open until Joel merges the changes into the trunk.

B.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

Merged to trunk@4361.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

Merged to trunk.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

swampwallaby-work@4366 has some cosmetic fixes to the properties package. Missing licence text, Id lines and some raw Class fixups.

B.


Brent Easton
Analyst/Programmer
University of Western Sydney
Email: b.easton@uws.edu.au


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Joel,

swampwallaby-work@4369 has a fix for

RFE [2193791] Pieces in palette to show correct dynamic property values

It turned out to be a fairly easy fix and should not affect performance. PieceSlot now returns a fully expanded piece when asked one instead of an unexpanded one. This fixes teh display DP values in the palette where the DP is defined in a prototype. It also fixes ‘Bad Data in Module’ errors when you first open the piece palette.

Tim, I solved this while playing with Combat Commander and also looked at the ‘Bad Data’ errors for ‘$Allied Orders$’ you get when you first start a new game. This turned out to be problem at your end. The Setup Stacks Allies OR and Axis OR have pieces that defined a numeric Dynamic Property with an initial value of $Allied Orders$ or $Axis Orders$. These need to be numbers.

Joel, Michael, Rodney, I did a test implementation of some of the PropertyProvider caching we discussed offline, but it had little measurable effect on my testbed (Combat Commander). I implemented it for SELECTED, SNAPSHOT and PIECE_ID. Since it had so little effect, I hesitate to add it to beta 5 as there may be unintended consequences. I think someone needs to review this whole area in more detail for 3.2. There are a whole bunch of gotcha’s just waiting to jump out.

The fixes already in solve the 2 major issues that was affecting the Stategos module.

B.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Starting to get a lot of duplicate bugs coming through the Bug Tracker from people still using beta 3.

B.


Brent Easton
Analyst/Programmer
University of Western Sydney
Email: b.easton@uws.edu.au


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Joel,

swampwallaby-work@4370 has a fix for:

Bug [2175571] NoSuchElementException in ColorConfigurer.stringToColor()

Colorconfigurer does not cope with corrupted input at all. There was FIXME there as to whether it should actually throw an error. I don’t think ColorConfigurer.stringToColor() should, but should return a valid color with the offending components set to 0 (ie black if it is total junk).

This bug looks to be due to a corrupted preference. If there is still a problem in the saving of the preference (which I can’t see), then users will report some Color preference not ‘sticking’.

B.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

I know, but we can’t do anything about it. Beta3 reports directly to SF,
and has no update notifier. That won’t happen with beta4, since we can
shut off bug reporting and it will pester people who are using it once
beta5 is released.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

Shouldn’t it also send a BadDataReport to the log?


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Perhaps, you’ll have to put the old code back.

B.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Tim, I solved this while playing with Combat Commander and also looked at
the ‘Bad Data’ errors for ‘$Allied Orders$’ you get when you first start a
new game. This turned out to be problem at your end. The Setup Stacks Allies
OR and Axis OR have pieces that defined a numeric Dynamic Property with an
initial value of $Allied Orders$ or $Axis Orders$. These need to be numbers.

Ahh! Found it! Don’t know how it changed though
Still getting the Bad Data error but it is not telling me where anymore.
I have narrowed it to two areas - The forementioned Palette Piece / DP
discussion upon opening palette in game or the use of CP’s as it always
seems to pop up when I edit protos that are reliant on DP’s / CP’s in editor


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

Merged to trunk@4371.

I think these fixes are probably fine as far as they go, but I’d be in favor
of rethinking the design for 3.2 instead.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

Merged to trunk@4372.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

swampwallaby-work@4380 contains a fix for:

Bug [2176550] NumberFormatException in PositionOption.setValue()

It is a rare bug that can result from a naming conflict. I have changed the bug reporting to detect the naming conflict and report a BadDataReport with a suitable message, instead of a bug report.

B.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

Merged to trunk@4381.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Joel,

Still outstanding to be merged is swampwallaby-work@4360

Bug [2202296 ] Hang when moving trait up

B.

*********** REPLY SEPARATOR ***********

On 5/11/2008 at 7:37 PM Joel Uckelman wrote:


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

I’ll get that now. I got tied up in following the election yesterday, in
addition to having had an awful cold almost the whole time since I returned
Australia. I feel like I’m flipped to my reduced side right now.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

Merged to trunk@4388.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)