Please feel free to take a look. I can’t use the VASL.mod out there because those released VASL mod builds are still using the MappedBufferedImage.class that you took out in Vassal 3.2. Now I think I realize why I am the only one who have seen it.
The VASLmod file that I use for testing is built with a modified ASLBoard.java in the ASL-src tree that removes its dependency on the missing MappedBufferedImage.class. For some reason, I thought that you checked that change into ASLBoard.java but then as I just checked, it is still not there.
I am also attaching all the Bad Data error outputs.
I just checked in the change in ASLBoard.java to my branch that removes
its dependency on the MappedBufferedImage.class.
You also checked 7993 into the trunk. I try to review the code going
into the trunk, so I’d prefer if you’d let me merge to the trunk
instead. (The change looks ok, though.)
Sorry about that. I thought I checked it only into my branch. I have
not looked into that problem since my last post as I was waiting for
your reply.
It’s not a problem, just wanted to let you know for the future.
I wonder if the packaging of the VASL.mod needs to be done in a
different way as I don’t see how your code change affects only VASL but
not others.
VASL has numerous custom classes which extend ones in VASSAL. My guess
is that one of them is extending a class in a way which was ok in 3.1
but is not ok in 3.2.
I might see if there’s anyting I can do this evening.
I just updated the latest VASSALengine 3.2 code and noticed that the latest changes broke the ASL src code in at least six files. For example, in ASLHexGrid.java, it has:
public class ASLHexGrid extends HexGrid {
…
public ASLHexGrid(double height, boolean alt) {
super(height, alt); ---------> error now in Eclipse IDE after updating the VASSALengine code.
}
Going back to HexGrid.java, I noticed that the latest version of this file had a huge change and that constructor needed by ASLHexGrid above is no longer there. HexGridX.java also does not have it.
I guess I need to dig a bit more to see what is going on with the new VASSALengine code.
I just updated the latest VASSALengine 3.2 code and noticed that the
latest changes broke the ASL src code in at least six files. For
example, in ASLHexGrid.java, it has:
public class ASLHexGrid extends HexGrid {
…
public ASLHexGrid(double height, boolean alt) {
super(height, alt); ---------> error now in Eclipse IDE after
updating the VASSALengine code.
}
Going back to HexGrid.java, I noticed that the latest version of this
file had a huge change and that constructor needed by ASLHexGrid above
is no longer there. HexGridX.java also does not have it.
I guess I need to dig a bit more to see what is going on with the new
VASSALengine code.
Ah, right. I suspected this might be a problem. These changes come from
Pieter’s refactoring of the grid code.
Pieter, can you advise Lance on what needs changing for VASL?
Let me upload the screenshot of the errors that are left so far. I have sort of fixed up something on the ASL side. Let me know if I should post the screenshot in another thread. Thanks.
