The Star Wars: Armada module has since time immemorial used the Load continuation function to allow each player (2 or more) to load their fleets.
Player 1 creates the table, then loads his fleet by importing a log file (created by a script) and stepping forward.
Player 2 repeats this to bring his fleet in.
Saves a TON of time.
But in 3.7.15 this does NOT work anymore.
Player 2 gets the error message:
NEW GAME NOT ALLOWED, which goes on to explain that only the OWNER of the room my load continuation.
WHEN/WHY was this changed and for what reason? Can we get it reverted ASAP? Otherwise, we have to go back to using an older version of Vassal.
Didn’t catch this during testing bc I was only testing as player 1…
The last public build for the module was done on 3.7.2 and then it worked fine.
Regards.
See issue 13022 for some background and the code commit (January 2024). It looks to me like it was addressing something else and not contemplating your use case.
2 Likes
The rationale for that change doesn’t apply to Load Continuation either. Also, the effect of Load Continuation can be undone.
I tried to understand what was going on here, but didn’t really succeed…
Anyway. So this means that since 3.7.7 this has been broken (in regards to how we use it)?
So we have to roll back or live with it (which we can’t, 100% impossible)?
I don’t have any answers beyond the very limited way I could move the ball down the field. The error message you described helped me search the code base to find it, and from there I was able to figure out when it was introduced.
From here, you’re going to need @Brent_Easton or someone else familiar what the issue that led to this change. I can only speculate that it was to fix something else, not specifically targeting the behavior you’d relied on (probably an unintentional knock-on effect).
1 Like
Any chance of having this change reversed so load continuation reverts to working like it used to?
I’ve raised an issue record for this problem. My novice reading of the the Vassal code is that the restriction for continuation files could be removed by adding this loadContinuation check in GameState.java (line 205-207) -
if (loadContinuation.isEnabled() || isNewGameAllowed()) {
loadGame(true);
}
I’ve not tried this out yet. It would be useful to have a view from @Brent_Easton as to whether this fix will work and would still achieve the goals of the original PR.
Update: Code fix condition swapped around. Initial test successful. Test build to follow.
2 Likes
@greenknight - please try a suitable build from here and let us know if it works for your group.
tip: If you are using Windows, you most likely need the build ending windows-x86_64.exe, if MacOS then macos-universal.dmg.
1 Like