I’ve uploaded 3.1.0-svn5146 for testing. Please check to see whether this build works for you and everything looks ok. If so, I propose that we release this build as 3.1.0.
The version mismatch error is reporting as:
This module was created using version 3.2.1 of VASSAL. You are using version 3.1.0-svn5146, which is older. Its recommended that you upgrade to at least VASSAL {0} before using this module.
B.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
This was caused when the double quote was changed to a single quote in
GameModule.version_warning_message=This module was created using version {0} of VASSAL. You are using version {1}, which is older. It’s recommended that you upgrade to at least VASSAL {0} before using this module.
Single quite are used by MessageFormat to allow literal {n} strings to be included in a message.
Which just reinforces our need to do something about how we are handling the quotes in the VASSAL.properties file.
B.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Thus spake “Brent Easton”:
This was broken by Rodney’s last commit. See here:
vassalengine.org/forums/viewtopic.php?t=1683
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Amen. I will admit to having been confused here. I noticed that some messages were displaying with double-quotes (e.g. I’'m back) and changed a bunch of them. Is the problem that our MessageFormat code is putting extra significance to having a single-quote? If that’s true, why do we need it? Surely Java’s translation mechanism has a way to insert literal { characters into the text.
rk
Post generated using Mail2Forum (mail2forum.com)
As far as I know, MessageFormat IS the standard Java Mechanism and the way to insert literal {'s is to quote them, thus requiring that single quotes be escaped by doubling them up to insert a single quote.
We don’t actually need to insert literal {'s or }'s into our messages, we don;t use them in any message except for argument place holders. Our problem is that we need to insert literal single quotes and the current mechanism uses single quotes to enter literal strings.
I’m with Joel, let’s go to a completely different mechanism that does not treat single quotes as special characters.
B.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Thus spake “Brent Easton”:
Do you want to do it or do you want to wait for me to do it? I think the
change is pretty well trivial-- it’s just a matter of switching from
MessageFormat.format() to String.format() in Resources, and then adjusting
the properties files.
I’m still fighting with making the site look uniform. I HATE doing web design
so I expect that doesn’t make it go faster.
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
I’ll look after it today…Rk, are you happy OK if we go ahead?
Error.data_error_message=Bad Data in Module: {0} {1}
becomes
Error.data_error_message=Bad Data in Module: %1$s %2$s
B.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
I’m fine with it. Given that the confusing behavior is built into the Java library, this seems like the lowest-impact way of fixing it.
rk
Post generated using Mail2Forum (mail2forum.com)
Joel,
swampwallaby-3.1@5150 has the fix. Straight forward and works nicely.
B.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
swampwallaby-3.1@5151 has the rest of the fix for
Bug [2621493] Not all text can be translated
- Fix Deck Global Key Commands
There is possibly (probably!) other text in modules that cannot be translated. Please let me know of any that people discover.
The 3.0 module translation facility has obviously not been used as it had many problems.
B.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
swampwallaby-3.1@5155 has the some additional module translation fixes - untranslatable fields and fields that should not be translatable.
Bug [2621493] Not all text can be translated
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Thus spake “Brent Easton”:
Thanks.
Merged to 3.1@5156, trunk@5157.
For the messages which have only one argument the ‘1$’ isn’t necessary,
but it also doesn’t hurt anything, so I left it alone.
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Thus spake “Brent Easton”:
Merged to 3.1@5158, trunk@5159.
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
I’ve checked the candidate over, and without doing detailed regression testing (on my todo list), everything seems to be working fine from my end.
- M.
2009/2/24 Joel Uckelman <uckelman@nomic.net (uckelman@nomic.net)>
Post generated using Mail2Forum (mail2forum.com)
Thus spake “Brent Easton”:
Merged to 3.1@5161, trunk@5162.
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
I’ve uploaded 3.1.0-svn5163, which corrects the single quotes problem, and picks up a few other small outstanding changes.