Eliminating uses of deprecated code in VASL6.6.2

I now have VASL6.6.2 working on VASSAL3.5.0-beta2. I see some additional references to deprecated code when I build with maven.

I am going to start eliminating those. A large number relate to the boardPicker classes in VASL and I will need some help there. I have discussed this previously with Joel on Github. In particular, we are having a problem with the getImageSize() function. Joel wrote: “I see what the problem is in Overlay: It looks like you’re reading the overlay images from a file which isn’t the module file. I hadn’t known you were doing that. This is going to require some thought about how to proceed. I may need to make some additions to how image loading works in VASSAL to accommodate this.” Any suggestions on how to proceed yet?

In addition, VASL includes a number of references to VASSAL.tools.io.IOUtils which has been deprecated and marked for removal. On looking at the class in VASSAL3.5.0-beta2, there is no indication as to an alternate class which should be used instead?

Thus spake drimmer:

In addition, VASL includes a number of references to
VASSAL.tools.io.IOUtils which has been deprecated and marked for
removal. On looking at the class in VASSAL3.5.0-beta2, there is no
indication as to an alternate class which should be used instead?

Use org.apache.commons.io.IOUtils.

VASSAL.tools.io.IOUtils subclassed that. It’s likely you’ll need to
adjust only the import.


J.

That seems to work. The methods in org.apache.commons.io.IOUtils are themselves deprecated but are not marked for removal so we should be ok for a while at least.

There were about half a dozen VASL classes using VASSAL.tools.io.IOUTILS. I have replaced all the imports with org.apache.commons.io.IOUtils and VASL is building and running ok so far. Maven is showing a small number of methods marked deprecated and marked for removal in the VASL build. Mainly getImageSize, getImageInputStream, and getCurrentImage() in VASSAL.counters.Embellishment.

I gather everything is sorted now, following my replies on GitHub?

Yes. Thanks for the help.