Global key cmd "Suppress individual reports" bug

G’day all,

My module has a number of cards with each card having a “Return to deck” command set to “CTRL R”. Then I have a “Report Action” command that is set also to “CTRL R” with the following text displayed in the chat window: “$playerName$ returns the $oldPieceName$ to $mapName”.

I then created a GKC to send all the cards back to the deck with one press, once again setting “CTRL R” as the key command. The “Suppress individual report” checkbox is checked and the following text is displayed: “$playerName$ returns all cards to the deck”. This, of course, is invaluable when you have played 10 cards and you don’t want to send each card individually back to it’s deck. The card deck is located on the same window as the GKC. This works with no problems.

However…

I then decided to move the the deck to another map window. When the GKC is pressed, it sends all the cards to the deck in the new map window, however the individual reports are now displayed. This causes the chat window to be inundated with a report message for each card.

Admittedly, not a showstopping bug, but annoying nonetheless.

LB

Have found and fixed the problem in

swampwallaby-3.1@6038

Bug [2844284] Global key cmd “Suppress individual reports” bug

The fix will be included in Vassal v3.1.11.

B.

*********** REPLY SEPARATOR ***********

On 24/08/2009 at 7:10 AM LurchBrick wrote:


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

Merged to 3.1@6039, trunk@6040.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Vassal version 3.1.11 has fixed the “Suppress individual reports across maps bug when using GKC”.

However, individual reports are not suppressed when the GKC is used for units that are all on the same map.

I cannot reproduce this. Can you pls supply a module that shows this happening.

B.

G’day Brent,

I tried recreating the problem in a brand new module, but it worked perfectly. So here is the module where it doesn’t work:

oldscratch.smackwell.com/trial/bm08.zip

Place a few pieces on to the main map.
Press the “Return Cards/Return Units” toolbar menu.
Select the “Remove your units” option.

All the units will be deleted but the individual reports will still display.

The GKC is located in the “Battle Mat” map window. The delete command is located in the Game piece prototype called “Bothsides”. (This prototype is fairly crowded. :astonished: )

Thanks for taking the time to look at this.

In the BM module, the unsupressed message is for a Delete trait. It turns out that Delete is a special case. The pieces is Deleted before it get’s reported, and this then interferes with the supression of the message.

I have fixed the problem and committed it to

swampwallaby-3.1@6062

but unfortunately, you will need to wait until version 3.1.12.

Regards,
Brent.

*********** REPLY SEPARATOR ***********

On 4/10/2009 at 3:38 PM LurchBrick wrote:


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

Merged to 3.1@6067, trunk@6068.

3.1.12 might not be all that far off, as one of the bugs I put in a fix
for a few hours after releasing 3.1.11 (another PNG transparency bug) is
awfully irritating.

I’ve uploaded 3.1.12-svn6069 which is a test build containing Brent’s fix.

nomic.net/~uckelman/tmp/vassal/


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)