Notes Feature Improvements

I was playing Pacific War last night, and noticed a few annoying behaviors of the Notes feature. We were trying to use it to bid in real time. Both of us would enter our bids, then once that was done, we both would reveal them.

  1. In order for your delayed note to be revealed, you had to save the dialog.

  2. Saving the dialog closed it and required it to be reopened.

This was version 3.1.14. I don’t know what version my opponent was using.

Is this how it’s supposed to work?

Is anyone working (or finished working) on changing this for 3.2?

Thus spake “jimcot”:

I’m generally against dialogs displaying persistent information where
changes don’t take affect immediately. What do you propose as a change?


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

I was thinking the opening and closing of the dialog should be totally separate from manipulating the contents, in this case the notes. I would like to see you be able to add/edit/reveal/delete individual notes while keeping the dialog open. Right now, it seems to be that you have to save (and close) the dialog before your notes are saved. You also have to save (and close) the dialog before your reveal action happens (i.e. it’s sent to the other players).

Additionally, It would be helpful to allow for multiple private, public and scenario notes (complete with titles).

Each note, regardless of type, would be manipulated individually, and changes should be saved or canceled. It would also be good to have a change indicator for each note identifying which notes have changed. In effect, any changes done in the Notes dialog would be reflected in the game state.

The notes would persist without the dialog and would be saved or discarded along with any saved game info based on the response from the user.

Thoughts?

Note: I worked on this recently (well, a year ago) and the changes are still waiting to be checked and committed!

Thus spake “bsmith”:

I remember. I haven’t been able to return to evaluating those changes
yet. I will once I’ve cleared away all of the site work.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

I’d be happy to take a look at it. Where can I find it?

Thus spake “jimcot”:

That I haven’t acted on these patches is only partly due to lack of
time. Last time I looked, I also disagreed with some of the design
decisions, and I’d like to get those issues resolved before merging
these patches. I’m traveling today and tomorrow, and then have
guests until Saturday. I’d appreciate it if this could be put off
until next week.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)