I just sent in a bug report on a problem with Place Markers. I’m using svn4525 and I’ve just noticed this problem.
Any attempt to edit a Place Marker attached to a piece generates a bug report and I can’t edit the Place Marker. If I run the game, and I activate a piece that has a Place Marker attached to it, the Place Marker will be placed and act normally but many other functions in the game will stop operating.
Thus spake “Dr_Nostromo”:
This appears to have started with the change in trunk@4431. That was a fix
for a similar problem, but in this case pieces coming from PieceDefiner
don’t have their gpidSupport set, and so the fix doesn’t work for this.
Brent?
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Thus spake Joel Uckelman:
Additionally, I believe that Bug 2198485 has the same cause as this bug,
so I’ve assigned that back to you.
sourceforge.net/tracker2/index. … tid=594231
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
swampwallaby-work2@4539 (NB. Not swampwallaby-work) should fix these:
Bug [2344403] gpidSupport not set on pieces coming from PieceDefiner
Bug [2198485] NPE in PlaceMarker.updateGpId()
Brent.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Thus spake “Brent Easton”:
Should I pick up both 4538 and 4539?
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Give me 10 minutes. I’m just creating a fresh branch from trunk, I must not have selected trunk when i made work2.
*********** REPLY SEPARATOR ***********
On 26/11/2008 at 12:17 AM Joel Uckelman wrote:
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Use swampwallaby-work3@4542.
I am also unable to open a log file using a fresh branch from the trunk.
B.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Thus spake “Brent Easton”:
Merged to trunk@4543.
I’ll get after that in a few minutes.
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Thus spake “Brent Easton”:
I can’t replicate this (even after switching to the native file chooser
on Linux). I need an error log from the current trunk.
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Just sent one in.
B.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Thus spake “Brent Easton”:
That’s not from the current trunk, it’s from beta5.
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Thus spake “Brent Easton”:
I found the problem. SwingUtilities.getAncestorOfClass() always messes me
up because it returns only proper ancestors, and in my line of work
people almost always say “proper X” (e.g., for X = subset) when they know
that they have a proper X and not just an X. Hence, my expectation is that
SwingUtilities.getAncestorOfClass(Frame.class, component)
will return component if component is a Frame, since component is its own
0th-level ancestor. (You are your own ancestor, just not your own proper
ancestor.) This happens to me pretty much every time I use this method.
It should be fixed in trunk@4544.
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)