"Place Marker" Triggering Automatically

[RedSatoshi]

I don’t see any post with a similar problem, so I’ve decided to start a post. I’m currently updating an extension for a card game which just introduced tokens, and so I want to include the feature of tokens by using the “place marker” function on the cards which can generate tokens. However, as the title states, I don’t know why the function would trigger automatically when a card possessing the function is moved between the public play area (in my module it’s called the “field”) and either player’s hand area. The problem seems to also trigger when I move the card from the field into the deck area. The problem doesn’t happen with any other area in the module.

I’ll include images to show the current settings.

This image shows the current traits a card would have (without the “place marker” function). The top trait (1) which I couldn’t screenshot is “Does Not Stack”.

These 2 images show the properties within the “place marker” function.

This image shows the properties of the marker itself.

I’ll also include a download link to the module and the extension. Currently, I’ve added the “place marker” function as a “Game Piece Property Definition” inside the module as “Rig Avatar Dragon”, and then apply said definition as a property to the cards which generate tokens.

In the Drive link, the module is the last file called “BSOB (1).vmod”, and the said extension with the cards that generate tokens is “15 - Contract Saga - True”. Said cards are in specifically SD69 in the “starter deck” section.

Drive link: Vassal Extensions – Google Drive

Thank you in advance. Please let me know if there’s any more information I have to provide.

[JoelCFC25]

This is at least part of your issue:

Check the config of your primary map window, the play area–you have Alt+Ctrl+Shift+X bound as the keystroke for what to apply to all pieces ending movement there. In the trait I’ve circled above, the prototype is responding to this with Ctrl+M–the same keystroke you’ve bound to the Place Marker trait. Ctrl+M is also in use on the Mask trait.

Stuff like this is why I use actual physical key combos very, very sparingly and only for things a user might ever frequently want to invoke via keyboard as opposed to right-click. Named commands are far easier to keep track of because you can name them according to the function they perform and greatly reduce the likelihood you end up duplicating keystrokes.

[shilinski]

I strongly second what Joel says. Instead of Ctrl+alt+shift+X, you should use a command string like “revealThisCard” or whatever it’s supposed to do. There are 3 reasons for this.

1. You will stop royally screwing yourself like you did here.
2. It documents what you are doing. If you or anyone re-visited this module say a year from now, they’d run away screaming.
3. 3. As is, a player could accidentally press a key combo you don’t want pressed and get bizarre behavior. That can’t happen with string commands.

[RedSatoshi]

Sorry for the late reply. Thank you guys! The issue was solved by omitting the keystroke. I wasn’t the creator of the module, just a successor to manage it, so I didn’t add all those keystrokes, nor did I realise how they’d affect the system until now. I’ll also try adding command strings from now on.