plan for wrapping up 3.1.0

Unless we find some utterly catastrophic problem with beta6 which necessitates
rushing out a fix, I’d like to make beta7 the final beta before releasing
3.1.0. Ideally, I’d like to go back in time and release 3.1.0 in April, but as
that seems not to be in the cards, I’ll settle for releasing it before the end
of the year. Today being 1 December, this means we have 31 days to do that.

Here’s what I see us having left:

  1. Translations. I’m still working on getting the translation keys in order.
    This is my personal highest priority right now, because our translators can’t
    get to work on it until I’m done, which means that I’m the bottleneck on this
    one. In order to expedite this, I’m going to start posting translation keys
    for which we still need messages written in English, and soliciting candidate
    messages from people here.

  2. App icon. What’s left to do on this is an hour’s work, tops. I’ll take
    care of this one, but it can come close to the end of the beta7 work, since
    it neither depends on nor is blocking any other issues.

  3. Bugs. Here, I see two categories: (a) bugs which are in the tracker, and
    (b) bugs which are not in the tracker.

(a) For bugs which are in the tracker, we’re in pretty good shape right now.
I’m classifying these into three categories: Must Fix, Should Fix, Might Fix.

Must Fix:

  • 2219448: Can Synchronize with players in Locked Rooms
  • 2358673: Piece transparency in LOS looks weird at non 100% zoom
  • 2368783: NPE in SourceTileOpBitmapImpl.eval()

Should fix:

  • 2314707: bad error reporting path for memory-mapped images
  • 2302536: NPE after exhausting the heap during image loading
  • 2286742: IllegalArgumentException in WizardSupport.showWelcomeWizard
  • 2199683: NPE in GameState.addPiece()
  • 2265820: StackOverflowError in LaunchButton$1.actionPerformed()

Might fix:

  • Everything else

I think we must fix the Must Fix bugs before releasing beta7, we should fix
the Should Fix bugs, and if we fix anything else, that’s great, but the
Might Fix bugs shouldn’t hold us up. (Please tell me if I’m missing anything
here, or if you think I’m miscategorizing these.)

Among the Must Fix bugs, 2219448 is being discussed here:

vassalengine.org/forums/viewtopic.php?t=1376

and 2358673 is being investigated here:

vassalengine.org/forums/view … 5&start=15

The last one, 2368783, I’m looking at myself.

Among the Should Fix bugs, I’m looking at 2314707 and 2302536, and I’ve asked
Rodney to look at 2199683. We have a fix already for 2265820, which I’m still
a bit uncomfortable with. For 2286742, I haven’t been able to obtain a copy
of the module—no reply from the module designer, and as this is a commercial
module, the user won’t give it to me. I’d like for us to fix this one, but
if they refuse to help us, then it’s going to stay broken.

(b) For bugs which are not in the tracker, we’re in much worse shape. We
don’t have a list of them, so we can’t check what’s remaining. These bugs are
almost exclusively ones which don’t generate exceptions and so were reported
direclty in the forum.

The first thing which needs to be done for these is for somebody to collect
all of the bug reports which have only been posted to the forum and put them
into the tracker so we have them organized in a manageable way.

Can I get a volunteer for this? (Preferably someone who is not already working
on something!)

  1. VASL and VSQL bugs. There are quite a few of these in the tracker right
    now. I don’t know how many of them are current—it’s possible that many of
    them are not. In any case, I think we’re very near the end of churning around
    the API for classes which are new since 3.0, and so it would now be worth it
    for someone to look at all of the VASL and VSQL bugs.

Ideally what we should do is add a bug to the bug tracker when we hear about it. I haven’t been doing that either. I did a grep of my e-mail for “bug” with disappointing results…

  • M.

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Michael Kiefte”:

Or if we could train users to do it, though that might be asking too much.

I keep every single piece of mail which might indicate a bug—so I do have
all of these messages—it’s just that they’re mixed in with a whole slew
of other VASSAL mail which I’ve kept for other reasons. So if someone wants
to go through the 600 or so messages which I’ve kept, and then look at the
threads in the forum to which they belong, I’ll supply the messages.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Can you think of a way to filter these down a bit? What sort of VASSAL e-mails have you been stashing like this?

  • M.

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Michael Kiefte”:

Anyting I want to revisit at some point. My vtodo box has 575 messages,
and my vassal box (longer-term things) has 455 messages. Only the vtodo
box is relevant for 3.1.0.

One thing I could do is grep all of the thread links from the messages—
that would be a start. I only come up with 248 unique threads that way,
though that only covers messages sent by people via the forum, not via
the list, and also not messages sent directly to me.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Michael Kiefte”:

I’m starting to cull ones which I know are taken care of or out of date,
and sending RFEs to the other folder, so we’re down to 550 now from 575.
I’ll keep at this, and hopefully will be able to present someone with a
more reasonable number of issues to follow up.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Michael Kiefte”:

I culled out everything which I know is resolved or won’t be worked on
for 3.1, and now have this down to 161 messages.

If I gave you the first 50 or so, would you like to take a crack at them?
I suspect that the most of them will be things which are either resolved
or so hopelessly out of date that we don’t know what they’re about anymore,
but then at least we’ll know that.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Sure, give them to me. If I’m too slow I’m sure I can surrender them to someone else :slight_smile:

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Michael Kiefte”:

Ok, you asked for it.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Update:

These bugs form the Fix lists are fixed now:

  • 2368783: NPE in SourceTileOpBitmapImpl.eval()
  • 2314707: bad error reporting path for memory-mapped images
  • 2302536: NPE after exhausting the heap during image loading

I’m adding these four to the Should Fix list and plan to work on them this
evening because I think I understand them now (they’re all closely related):

  • 2390630: Connecting to server blocks GUI when server is down
  • 2315230: ConnectException in HttpRequestWrapper.doGet()
  • 2162266: NPE in HybridClient.setDelegate()
  • 2129550: UnknownHostException in HttpRequestWrapper.doGet()

So, here are the current lists:

Must Fix:

  • 2219448: Can Synchronize with players in Locked Rooms
  • 2358673: Piece transparency in LOS looks weird at non 100% zoom

Should fix:

  • 2286742: IllegalArgumentException in WizardSupport.showWelcomeWizard
  • 2199683: NPE in GameState.addPiece()
  • 2265820: StackOverflowError in LaunchButton$1.actionPerformed()
  • 2390630: Connecting to server blocks GUI when server is down
  • 2315230: ConnectException in HttpRequestWrapper.doGet()
  • 2162266: NPE in HybridClient.setDelegate()
  • 2129550: UnknownHostException in HttpRequestWrapper.doGet()


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Update:

These bugs form the Fix lists are fixed now:

  • 2390630: Connecting to server blocks GUI when server is down
  • 2315230: ConnectException in HttpRequestWrapper.doGet()
  • 2162266: NPE in HybridClient.setDelegate()
  • 2129550: UnknownHostException in HttpRequestWrapper.doGet()

Here are the current lists:

Must Fix:

  • 2219448: Can Synchronize with players in Locked Rooms
  • 2358673: Piece transparency in LOS looks weird at non 100% zoom

Should fix:

  • 2286742: IllegalArgumentException in WizardSupport.showWelcomeWizard
  • 2199683: NPE in GameState.addPiece()
  • 2265820: StackOverflowError in LaunchButton$1.actionPerformed()


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

I have been completely unable to reproduce this problem, and neither has the person who originally reported it.

Our testing indicated that while you can synchronize with a player in a Locked room (which should probably not be allowed), any commands you issue are not sent to players in the locked room, so you are unable to affect their game.

I believe this bug should probably be closed and replaced by the RFE to add Kick/Mute facilities to rooms.

B.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

Becaus–as you say—it shouldn’t be permitted to sync with players in locked
rooms, it’s still a bug, but not the urgent problem we thought it was. So
I’m returning the urgency of this one to normal.

What about his RFE?

sourceforge.net/tracker2/?func= … tid=594234


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)