plan for wrapping up 3.1.0

Thus spake Joel Uckelman:

Update:

Must Fix for beta7:

NONE! So I’m going to do a build for beta7 soonish.

Must Fix for 3.1.0:

  • 2432256: ArrayIndexOutOfBoundsException in Embellishment
  • 2372121: No exception in errorLog
  • 2286742: IllegalArgumentException in WizardSupport.showWelcomeWizard
  • 2265820: StackOverflowError in LaunchButton$1.actionPerformed()

Notes:

I haven’t returned to Brent’s solution for Bug 2265820 yet—I tried
something else with catching StackOverflowExceptions which didn’t work.

I find Bug 2372121 rather disturbing, as it means that something is broken
in our error reporting chain, and of course we can’t find where because the
errorLogs contain no stack traces.

We’ve had quite a few instances of Bug 2432256, so it wouldn’t hurt to
fix that before 3.1.0 is out.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Is this happening for more than one player/module? All of the ones I have seem seem to have been from the same module.

B.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

Here are the ones I was able to turn up:

Through the Ages: 1
Space Crusade: 1
Unnamed module: 1
WoW Minis: 1
Galactic Conquest: 1

So, that’s no two from the same module. This points in the direction of
it being our problem, not a module problem.

I’m going to look into this tonight, since the problem is likely in code I
wrote.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

I’ve seen at least half a dozen for Through the Ages, mostly generated by fatgreta1066@gmail.com, that was the module I was thinking of.

However, it is clearly a wider problem.

B.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

I’ve looked closely at this more than once and cannot see how it can happen, or why it only happens in getImageBounds() and not elsewhere

swampwallaby-work6@4747 contains additional logging code to get more information if it re-occurs in beta 7.

B.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

I’ve managed to reproduce this with the Axis and Allies Minatures module (one of the duplicates). Looking into it now.

B.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

Merged to trunk@4748.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Hi Rodney,

Can I please get you to look at this one? There seem to be a number of related problems in the Wizard that I can’t get my head around. You know this code much better than I.

You can reproduce the problems using the current version of the ‘Axis and Allies MINIATURAS v 2.0’ module available on the vassalengine site.

The problems I have found are:

  1. The IllegalArgumentException being thrown when trying to Play the module. There seem to be additional steps being defined that do not exist. You see these in the step list with a description of ‘…’. Once the ‘viewedTutorial’ preference is set to TRUE, the bug no longer occurs.

  2. There seems to be a problem when the splash image is fairly small - as in this module. As you go through the steps, the display in the right hand panel is displayed in the left hand panel also. This dissappears if you move the position of the verical bar.

  3. Related to Bug 2, the left hand panel does not refresh properly when you choose different options in the right hand panel.

B.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Cool! I, shamefully, still need to contact the people who provided the i18n translations, so I’ll get right on that.

rk

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Rodney Kinney”:

The French translation is already done, modulo the new keys which Brent
added for the kick/invite/lock functionality. I’ll point Gregory to the
half-dozen new keys.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

Any movement on this one?


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Haven’t had a chance to investigate.

rk

Post generated using Mail2Forum (mail2forum.com)