Brent, I changed two more small things in uckelman-working 3056:
- Editor can be opened after module is loaded, but before game started.
- “Edit Module” is disabled once Editor is created.
Now I’m really done.
Thanks Joel.
I’ve also just noticed that uckelman-working@3054 hasn’t been merged into trunk either. I’ll merge that manually into my stuff. Don’t worry about merging it into trunk, I’ve made too many changes.
Cheers,
Brent.
Thus spake “Brent Easton”:
I didn’t merge 3053:3056 to the trunk because I figured doing that would
cause trouble for you.
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Any particular reason for this restriction? You can start games while editing a module, so why not edit a module once a game has started?
On the other hand, I am not 100% sure I like the ‘Edit Module’ option on the File Menu like that. It just seems to be asking for trouble. I think I would prefer a ‘Module Editor’ option in the Tools menu.
I’m also thinking the PlayerWindow should probably be closed when the EditorWindow opens - You are ‘in’ one or the other.
Brent.
Thus spake “Brent Easton”:
As Ben pointed out, that could be catastrophic if you change something during
a game accidentally. I think we don’t want to open up that possibility, as
it only gives normal users an additional way to be unhappy.
It’s a one-line change in PlayerWindow if we want that. I have a weak
preference for having it under File, because (following Rodney) that
might encourage casual users to try it.
Why? If we did that, then you wouldn’t be able see what the PlayerWindow
looks like as you work on a module. I’d find that annoying.
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
My main problem with that is if that if no module is loaded, then it doesn’t Edit a Module at all, but opens the module Editor from where you must again select ‘File → Edit Module’ again.
Anyway, I have committed my basic changes in swampwallaby-merge@3061 - Back to you. This turns EditorWindow into a base class for ModuleEditorWindow and ExtensionEditorWindow.
One job I haven’t finished - The Load/New Extension options on the File menu should be disabled when the module is dirty. This needs a change in ConfigureTree and a way of passing the editing state back to the ModuleEditorWindow.
Cheers,
Brent.
Thus spake “Brent Easton”:
Are you objecting to (1) the name of the menu item in the player, (2) the
fact that it takes an extra click, (3) both, or (4) something else?
Great, thanks.
Don’t expect any progress from me before Thursday evening—right now I’m
preparing slides for a talk I give tomorrow at an event which looks like
it will last for about 13 hours.
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Basically (1) - The item is called ‘Edit Module’ in the File menu, but when no module is loaded, it doesn’t Edit a Module and it doesn’t open, close or manipulate any Files.
Brent.
Brent Easton
Analyst/Programmer
University of Western Sydney
Email: b.easton@uws.edu.au
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Thus spake “Brent Easton”:
That’s the easiest of the bunch to repair. Can you suggest a better name?
“Module Editor”? (Though if it’s called that, it should probably go under
Tools…)
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
On Feb 12, 2008, at 2:31 PM, Joel Uckelman wrote:
Well, I think that you may need two menu entries:
Edit This Module edits current module
Edit Module… brings up a dialog to choose module
The first item is only enabled if there is a module currently loaded.
The other item is always available.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Just a reminder that when I test the release I’ll be randomly clicking menu items (simulating users) while recording a logfile. so if there’s an item in Tools which could screw up a logfile then it may not pass testing 
Yes, that get’s my vote.
The ‘Module Editor’ command in tools would be disabled when a game is in progress.
I think just the one will do - If a module is already loaded, then ‘Module Editor’ will open the Editor editing the current module.
If a module is not already loaded, then ‘Module Editor’ opens the basic Editor window where you can then choose either Open or New from the File menu.
I still like the idea of having the -edit option open the Editor directly and having a seperate runfile for it as developers will probably use this. But we also have the ‘Module Editor’ option handy on the Tools menu of the Player where people can find it easily.
Thus spake “Brent Easton”:
The ‘-edit’ option is still there and should continue working.
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Thus spake “Brent Easton”:
Done, in trunk 3068.
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Thus spake “Brent Easton”:
It’s merged now.
-
Did you intentionally remove the accelerators for “Save” and “Save As”
in the editor? If so, why? -
What’s the blank menu item for in the editor’s Help menu?
ETA?
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Hi Joel,
No, that was inadvertant.
I don’t have a blank menu item in my editor’s Help menu?
I have ‘Help’ with a little icon, followed by ‘Component Help F1’, then a seperator, then ‘About VASSAL’
Working on it now. Couple of other small jobs also
- Close Extension does nothing. Should close Extension editor and redisplay Module Editor.
- Close Module command does nothing. Should return to an empty Module Editor.
Brent.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Actually, I’m not convinced they where there before I started my edits! I think they where already gone.
Brent.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Thus spake “Brent Easton”:
Would you add those back when you get a chance?
The “Component Help” entry shows up blank for me if I bring up the editor
prior to loading a module.
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Hi Joel,
I have fixed up a few things in swampwallaby-merge@3072
- Added Save and SaveAs accelorator keys
- Fixed missing ‘Component Help’ menu option in unloaded editor
- Added Close support, but have not yet written the close code
That’s all I have time for this morning. Feel free to take over if you have time.
Tasks remaining:
- implement ModuleEditorWindow.close()
- implement ExtensionEditorWindow.close()
- Track dirty status of ConfigureTree and callback to owning Editor if state changes. Use this to turn off Extension options in ModuledEditorWindow File menu when ConfigureTree is dirty.
Cheers,
Brent.
Brent Easton
Analyst/Programmer
University of Western Sydney
Email: b.easton@uws.edu.au
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)
Thus spake “Brent Easton”:
Merged. Thanks.
–
J.
Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org
Post generated using Mail2Forum (mail2forum.com)