Remaining tasks before 3.1.0-beta1

Thus spake “Brent Easton”:

Yes. I’ll do that, then. (You probalby saw when you worked on this that I
did that for some of the other menu items elsewhere.)

Ok.

That’s a good idea. I’ll try that and see how it looks.

It has my vote.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Michael Kiefte”:

You’re welcome to look into it. :slight_smile:

One reason I haven’t tackled it myself is that I don’t know quite where
to look.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

On 18/02/2008, Joel Uckelman uckelman@nomic.net wrote:

I haven’t tackled it myself because all I have to do is drag the sash.
The path of least resistance points to just dragging the sash. :slight_smile:

I have to track down a sticky getLocation bug in the meantime.

  • M.

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake Joel Uckelman:

This is fixed in trunk@3107.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “Brent Easton”:

Have a look at svn3107 (nomic.net/~uckelman/tmp/vassal/). I tried
something like what you said, but a bit fancier.

If people like it, I’ll commit it to the trunk.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

I like what you did. But why fade out the splash screen once it’s displayed? All this empty space deserves something to fill it :slight_smile:

IMHO, I would vote for a fade in and then leave the pictures displayed.

Thus spake “bsmith”:

I can’t replicate this. When I open a new module, I do get the prompt.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

I just tried again with the El Grande module Joel, with the same result, it could be Windows specific?

Ah, I see what’s happening now. I’ve got the wizard turned off in Preferences, so when I open a new module, it never prompts.

I would suggest when a user opens an entirely new module, it overrides the “No Wizard” preference and prompts for a username/password; Otherwise it’s way too easy to kick off games with the default user/password set.

I guess the ideal solution is to let the user configure the default username/password when they install Vassal, but that can wait for a later release.

Welcome aboard Robert! What about this, it fades in… then it fades some of the way out so we’re left with a kind of shaded and less obtrusive version of the Splash.

Joel is spoiling us!

By the way… It’s David. Only time I was called ROBERT was at school and in the army :slight_smile:

For now I’m experimenting with the Eclipse debugger to try to see what happens with the turn tracker and I admit I’m a bit lost there. But I managed to get Eclipse to run in debug mode and I’m fiddling around with breakpoints. Many things in my EuF2 module depends upon the TurnTracker working properly so for now I’m a bit stuck. But this was completely out of topic. Sorry.

About the splash screen fading in and the fading out to a translucent background, I would say it’s even better!

Thus spake “bsmith”:

We still need to get this working before releasing a beta, or its
going to give testers problems.

In 3.0 I see that the username and password are stored per module. Is
there a good reason for this, as opposed to storing a single username
and password? It would be simpler if the username and password were
global for each user, because then we could prompt the user for these
the first time VASSAL is run.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

It means it’s easier to keep track of multiple aliases if you want to be a shifty, anonymous player! But seriously no, I can’t think of a good reason, but Rodney may know more about the history of why it’s done the way it is.

And eventually, we could layer a few “Getting Started with Vassal” tips over it. Cool effects!

I have not been able to fix the bug yet. However, I did come across
some suspect code. Lines 382:388 of HexGridNumbering.java read:

protected int getMaxRows() {
return (int) Math.floor(grid.getContainer().getSize().height /
grid.getHexWidth() + 0.5);
}

protected int getMaxColumns() {
return (int) Math.floor(grid.getContainer().getSize().width /
grid.getHexSize() + 0.5);
}

Shouldn’t getHexSize() and getHexWidth() be swapped here? I can see
that this is never a problem until the hexes are out of proportion.

  • M.

On 17/02/2008, Michael Kiefte mkiefte@dal.ca wrote:


Michael Kiefte, Ph.D.
Associate Professor
School of Human Communication Disorders
Dalhousie University
Halifax, Nova Scotia, Canada
tel: +1 902 494 5150
fax: +1 902 494 5151


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Hi Michael,

Be very careful here. Not all is as it seems.

The hex numbering code is immensely complex to cope with sideways mode, odd column offsets and reversed numbering on each axis. It took me forever to get this stuff right. From memory, the hex ‘width’ specifies the distance between two edges, and the Size is the distance accross the hex, so this code is probably correct.

What exactly is the problem you are having? I might be able to point you in the right direction.

Cheers,
Brent.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

You’re probably right.

I found my bug anyway and it’s fixed in mkiefte-ADC2-import r3116.
Rodney or Joel, can one of you merge it to the trunk?

  • M.

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

Thus spake “bsmith”:

I’ve built a username/password dialog which should pop up in lieu of the
wizard, which you can find in svn3125
(nomic.net/~uckelman/tmp/vassal). I haven’t committed this to
the trunk yet, because it disables the welcome wizard entirely and, while
I would like to do that, I’m not certain that we have agreement on that
point.

Why is this happening? Is it because there’s not one defined in the module,
or because there is one but it’s broken in some way?


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

OK, thanks for that. Works fine!

It doesn’t seem to be happening in 3.0.17 Joel; Looks like something may have changed somewhere since then. Civil War does it as does OCS-Tunisia v3.3.

Thus spake “bsmith”:

AboutScreen has always been a required component. Some modules have a
null image for AboutScreen, which defeats the purpose of it, and leaves
a dead item in the Help menu.

I suppose that a better solution would be not to build AboutScreens
without images.


J.


Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)