The way Replace.matchTraits works right now, the traits have to be in the same order in both the original and replacing GamePiece. This isn’t very intuitive and it’s not documented.
If traits are not in the same order, it is very difficult to predict which ones will be updated and it depends on whether there are prototypes or not. The fix is easy but I don’t think it’s been reported as a bug. It’s pretty annoying and I’m sure people have been annoyed by this before me. Are there any objections to a patch for this?
You want me to patch it before 3.1.15? If so, it ain’t going to happen
before this weekend – I’m flat out until Thursday on unrelated tasks (i.e.,
my day job).
The way Replace.matchTraits works right now, the traits have to be in
the same order in both the original and replacing GamePiece. This
isn’t very intuitive and it’s not documented.
If traits are not in the same order, it is very difficult to predict
which ones will be updated and it depends on whether there are
prototypes or not. The fix is easy but I don’t think it’s been
reported as a bug. It’s pretty annoying and I’m sure people have been
annoyed by this before me. Are there any objections to a patch for
this?
I see that nobody commented on this. Do you still intend to patch it?
Are there any problems this would raise?
I’m going through my email backlog right now. I replied to a message
from 2005 yesterday.
You want me to patch it before 3.1.15? If so, it ain’t going to happen
before this weekend – I’m flat out until Thursday on unrelated tasks (i.e.,
my day job).
No, 3.1.15 is closed, barring any catastrophic new problems. We’ll pick
it up for 3.1.16.
I’m going through my email backlog right now. I replied to a message
from 2005 yesterday.
And I thought I was bad. I’m back to September. Most problems resolve themsel
ves.
That’s partly why I was able to reduce my inbox by almost 200 messages since
Sunday—I was carrying a lot of messages which were no longer relevant or
had already been handled.
Is this in the bug tracker? Otherwise I’m never going to remember this. I’d c
heck, but I’m on 3G.
That’s partly why I was able to reduce my inbox by almost 200 messages
since
Sunday—I was carrying a lot of messages which were no longer relevant or
had already been handled.
I’m down to 63! The race is on.
Is this in the bug tracker? Otherwise I’m never going to remember this.
I’d c
heck, but I’m on 3G.
Not sure what I was thinking on this one. I took a look at the code for Replace.java and I see that any alternative would be unworkable. See the comments for Bug 3216.