Understanding Complex Trigger Actions

[cholmcc]

Hi Mike,

@sfcmikej

Unfortunately, I can’t get the “Change-Property Toolbar Button” to work. It seems simple enough and I tested the logic in my Java IDE and it works as expected.

Why do you run things in an IDE? What do you hope to learn from that?

@sfcmikej

I can’t see a way to declare the Global Property as Boolean but my understanding is that BeanShell will infer the type by the value assigned. So I assigned it an initial value of false. It threw an error:

• Bad Data in Module: Source: {!AmmoPressed} Error: Expression evaluation error.

In your Global Properties definition, enable Is numeric. Then set the starting value to false.

@sfcmikej

I set up the report format on the “Change-Property Toolbar Button” to report the old value and the new value ({“AmmoPressed was " + oldValue + " and now it is” + newValue}) and this is what it reports:

* AmmoPressed was -1 and now it is

The blank after “it is” is correct. It is not changing the value of AmmoPressed and if I take the curly braces away the expression is treated as a String literal and the report returns: * AmmoPressed was -1 and now it is!AmmoPressed.

The {...} says to evaluate the contained code as a BeanShell expression, so those should not be removed. It seems like your Change-Property Toolbar Button expression is messed up and is interpreted as a string. Did you put {...} around it:

{!AmmoPressed}

so that it is evaluated as BeanShell expression? Anywhere you want an expression to be understood as a BeanShell expression, you need to put {...} around it.

You could, of course, set the initial value of AmmoPressed to 0, and in your Change-Property Toolbar Button expression have

{AmmoPressed == 0 ? 1 : 0}

and in your Layer trait follow expression

{AmmoPressed != 0 && LowOnAmmo ? 2 : 1}

@sfcmikej

Since I have set the Initial Value of the Global Property to false I am confused by the oldValue being -1. I think in programming languages that equate the Boolean true/false to a numeric value that 0 is false and not zero is true, so the -1 has me puzzled.

I think that’s because you probably didn’t enable the Is numeric check-box in your global property.

BTW, check How to format forum posts - a bit of formatting can make your posts much easier to read and understand your problem.

Yours,
Christian