Updating saved scenarios

[Brent_Easton]

Not a great name, but

getMapCollection()

That works for me.

Joel - swampwallaby-latest@2943 includes this refactor, plus a small change to the visiblity of PlaceMarker.createMarker() I need for the new game updater.

Feel free to rename it

Brent.

[uckelman]

Thus spake Thomas Russ:

On Jan 31, 2008, at 3:01 PM, Joel Uckelman wrote:

2927: Refactor Map.getAllMaps() to return Collection instead
of Iterator
(FIXME)

Is changing the return type a good way to fix this? Doing so ensures
that any custom code which called Map.getAllMaps() is broken now.
The FIXME (which I put there) was intended to remind me to create a
different function which returns a Collection (or a List?) and then
deprecate getAllMaps()—probably I should have been more explicit
about
that in the FIXME. I would have done it at the time instead of putting
a FIXME in, but I couldn’t think of a good name for the new function.

Not a great name, but

getMapCollection()

I was thinking getMapList(), if that’s not taken. (And return a List,
so that we return as specificly as we can.)

–
J.

---

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

[uckelman]

Thus spake “Brent Easton”:

Do you think GPIDSupport would be a better name for TopLevelComponent?

Sure, feel free to change things like that. I guess I was thinking Form rathe
r than Function. Potentially, there may one day be other not-gpid stuff that
will be shared between GameModule and ModuleExension. If they both has the sa
me parent class, I would have added a new parent instead.

Done. I called it GpIdSupport, following your capitalziation.

–
J.

---

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)

[uckelman]

Thus spake “Brent Easton”:

Not a great name, but

getMapCollection()

That works for me.

Joel - swampwallaby-latest@2943 includes this refactor, plus a small change t
o the visiblity of PlaceMarker.createMarker() I need for the new game updater
.

Feel free to rename it

Brent.

Done. I called it getMapList(), and it returns a List, which is fine
since that’s a subinterface of Collection.

–
J.

---

Messages mailing list
Messages@forums.vassalengine.org
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)