Place Marker or Replace with Other always selected

Module Design
#1

Currently, if a marker is placed (or a piece is replaced) the marker is always selected afterwards. This is not a problem when the marker was placed as a result of a right-click menu item or key stroke when the original piece was selected. However, if the marker was placed after some external trigger (like a Global Key Command) then all the markers are selected after placement whether the original pieces were selected or not.

This is kind of disturbing if you don’t expect it. For example, if the markers were generated due to a keystroke, the following keystroke, whatever it is, is applied to all the markers unless you explicitly deselect them.

This is easy to fix: the markers are only selected if the original piece was selected. The question is whether anyone actually relies on the current behaviour. Is anyone aware of any module where you expect all the markers to be selected even if the original pieces weren’t selected? If no, then the bug will just be fixed. Otherwise, we have to create a new option like “Only select marker if original piece selected,” which is going to seem pretty obscure (and the default will have to be “no”.)

This applies to Replace with Other commands which is a subclass of Place Marker.

#2

Without combing through every module to check and make sure, I’d hedge my bets and say: yes, probably someone does somewhere.
But if it is fixed ignoring obscurity, someone will report behavior change later on confirming this useage and one can always revisit and revise it again :slight_smile:

Im thinking it probably is more common than you realize, where a piece might through GKC place markers on other pieces and then deliberatly perform some function afterwards with all those markers (i.e increase a specific GP 1 for each marker placed - counting is a common thing to do) :slight_smile:

From: mkiefte messages@forums.vassalengine.org
To: messages@forums.vassalengine.org
Sent: Mon, March 1, 2010 12:29:26 PM
Subject: [Module Design]Place Marker or Replace with Other always selected

Currently, if a marker is placed (or a piece is replaced) the marker is always selected afterwards. This is not a problem when the marker was placed as a result of a right-click menu item or key stroke when the original piece was selected. However, if the marker was placed after some external trigger (like a Global Key Command) then all the markers are selected after placement whether the original pieces were selected or not.

This is kind of disturbing if you don’t expect it. For example, if the markers were generated due to a keystroke, the following keystroke, whatever it is, is applied to all the markers unless you explicitly deselect them.

This is easy to fix: the markers are only selected if the original piece was selected. The question is whether anyone actually relies on the current behaviour. Is anyone aware of any module where you expect all the markers to be selected even if the original pieces weren’t selected? If no, then the bug will just be fixed. Otherwise, we have to create a new option like “Only select marker if original piece selected,” which is going to seem pretty obscure (and the default will have to be “no”.)

This applies to Replace with Other commands which is a subclass of Place Marker.

Messages mailing list
Messages@forums.vassalengine.org (Messages@forums.vassalengine.org)
forums.vassalengine.org/mailman/ … engine.org

Post generated using Mail2Forum (mail2forum.com)